Focus on TOC when TOC is opened #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
focus-on-toc-when-toc-opens
branch
from
d363166 to
1838b76
Compare
TomWoodward
approved these changes
Jan 8, 2024
jivey
approved these changes
Jan 8, 2024
RoyEJohnson
force-pushed
the
focus-on-toc-when-toc-opens
branch
from
9807e98 to
ba4c792
Compare
RoyEJohnson
force-pushed
the
focus-on-toc-when-toc-opens
branch
from
a5eab91 to
41d80f7
Compare
RoyEJohnson
force-pushed
the
focus-on-toc-when-toc-opens
branch
from
a48544e to
2c7c787
Compare
|
@RoyEJohnson I merged a related card and this now has conflicts to be resolved |
TomWoodward
approved these changes
Feb 13, 2024
TomWoodward
reviewed
Feb 13, 2024
| }); | ||
| reactDomAct(() => { | ||
| sb?.dispatchEvent(new Event('transitionend')); | ||
| }); |
There was a problem hiding this comment.
the trick was that the event listener isn't added until the thing re-renders with the open prop, so you need to have the event dispatch in a separate act call after you update the open state
TomWoodward
had a problem deploying
to
rex-web-focus-on-toc-wh-nwxpz2
For: openstax/unified#2711 Also added an aria-label to HighlightsHelpInfo close button Update index.spec.tsx Delay setting focus Add space after comma in css
RoyEJohnson
force-pushed
the
focus-on-toc-when-toc-opens
branch
from
53d42e9 to
70ae22b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: https://github.com/openstax/unified/issues/2711
Also added an aria-label to HighlightsHelpInfo close button