Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label login nudge close button; force focus to stay on it #2066

Merged
merged 15 commits into from
Dec 5, 2023

Conversation

RoyEJohnson
Copy link
Contributor

@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-z11eyr October 30, 2023 19:10 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-z11eyr October 30, 2023 22:17 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-login-nudge-tab-behavior branch from f32064a to f2ec368 Compare October 30, 2023 22:40
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-z11eyr October 30, 2023 22:40 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-login-nudge-tab-behavior branch from f2ec368 to 38cc6fc Compare October 30, 2023 22:48
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-z11eyr October 30, 2023 22:48 Inactive
@RoyEJohnson RoyEJohnson marked this pull request as ready for review October 30, 2023 22:57
@RoyEJohnson RoyEJohnson requested a review from a team as a code owner October 30, 2023 22:57
@RoyEJohnson RoyEJohnson requested a review from jivey October 30, 2023 22:57
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-z11eyr November 1, 2023 20:59 Inactive
Copy link
Member

@jivey jivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a thought about the readability of the split component.

@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-z11eyr November 3, 2023 16:45 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-z11eyr November 5, 2023 03:56 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-z11eyr November 5, 2023 05:53 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-login-nudge-tab-behavior branch from 518a633 to c305516 Compare November 6, 2023 16:50
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-z11eyr November 6, 2023 16:50 Inactive
Copy link
Member

@jivey jivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I don't know why the build is failing though, it seems unrelated.

@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-z11eyr November 6, 2023 23:04 Inactive
@RoyEJohnson
Copy link
Contributor Author

Had to separate it back out (used "Maybe" for name) because the top level screens for presence of window which the mobile media detector requires.

@TomWoodward TomWoodward had a problem deploying to rex-web-fix-login-nudge-z11eyr November 7, 2023 19:43 Failure
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-z11eyr November 7, 2023 20:53 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-z11eyr November 8, 2023 13:10 Inactive
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-fix-login-nudge-wscul0 November 13, 2023 22:26 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-wscul0 November 16, 2023 15:54 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-wscul0 November 16, 2023 16:33 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-wscul0 November 16, 2023 20:42 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-wscul0 November 17, 2023 15:08 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-wscul0 November 17, 2023 15:13 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-wscul0 November 20, 2023 12:43 Inactive
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-fix-login-nudge-6oldvx December 1, 2023 17:11 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-6oldvx December 1, 2023 19:15 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-login-nudge-6oldvx December 5, 2023 15:01 Inactive
@staxly staxly bot merged commit 680cfb1 into main Dec 5, 2023
10 of 11 checks passed
@staxly staxly bot deleted the fix-login-nudge-tab-behavior branch December 5, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants