-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label login nudge close button; force focus to stay on it #2066
Conversation
f32064a
to
f2ec368
Compare
f2ec368
to
38cc6fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a thought about the readability of the split component.
518a633
to
c305516
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I don't know why the build is failing though, it seems unrelated.
Had to separate it back out (used "Maybe" for name) because the top level screens for presence of |
For: https://github.com/openstax/unified/issues/2589