Persist search string when navigating internal links #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
include-persistent-query-params-in-links-within-books
branch
from
d62fdf6 to
080be30
Compare
RoyEJohnson
force-pushed
the
include-persistent-query-params-in-links-within-books
branch
from
080be30 to
d72e777
Compare
RoyEJohnson
force-pushed
the
include-persistent-query-params-in-links-within-books
branch
from
d72e777 to
f58ed3e
Compare
Dantemss
requested changes
Oct 19, 2023
|
|
||
| const options = createNavigationOptions(systemQueryParams as SystemQueryParams); |
There was a problem hiding this comment.
These lines the linter is breaking down are really not that long...
| const additionalQueryString = new URLSearchParams( | ||
| persistentQueryParams as Record<string, string> | ||
| ).toString(); | ||
| const extendedSearchString = (search + '&' + additionalQueryString).substring( |
There was a problem hiding this comment.
You might have to do something when additionalQueryString is empty so there's not a & at the end?
There was a problem hiding this comment.
queryString.parse cleans this up. But that gives me an idea for a tidier solution.
| @@ -152,6 +152,7 @@ describe('contentLinkHandler', () => { | |||
|
|
|||
| it('intercepts clicking content links with slug', async() => { | |||
| const link = `/books/${book.slug}/pages/page-title`; | |||
| prop.currentPath = '/asdf?foo=bar'; | |||
There was a problem hiding this comment.
Is this unrelated? This seems to be the only instance in the PR of something changing that has to do with currentPath.
There was a problem hiding this comment.
I modified the test so that I could have one with a pre-existiing search string.
There was a problem hiding this comment.
I further modified the test to check the search string result.
RoyEJohnson
force-pushed
the
include-persistent-query-params-in-links-within-books
branch
from
f1a8b91 to
a2b2ec5
Compare
Dantemss
approved these changes
Oct 23, 2023
RoyEJohnson
force-pushed
the
include-persistent-query-params-in-links-within-books
branch
from
e2b0ad9 to
9b49c00
Compare
RoyEJohnson
force-pushed
the
include-persistent-query-params-in-links-within-books
branch
from
9b49c00 to
2772916
Compare
Malar-Natarajan
deleted the
include-persistent-query-params-in-links-within-books
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: https://github.com/openstax/unified/issues/2244