Increase code coverage 5 #2648
Merged
Increase code coverage 5 #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
increase-code-coverage-5
branch
from
458dd6f
to
c68f782
Compare
jivey
reviewed
Jul 29, 2024
| @@ -3,13 +3,10 @@ import {cnxFetch} from './table-of-contents-html'; | |||
| import memoize from 'lodash/memoize'; | |||
|
|
|||
| export function bookToc(slug: string) { | |||
| if (!slug) { | |||
There was a problem hiding this comment.
Is this guaranteed to not be empty, or maybe prefer to have the throw in cmsFetch?
There was a problem hiding this comment.
The only place it is called tests for slug.
| return cmsFetch(slug) | ||
| .then((bi) => { | ||
| const isRex = Boolean(bi.webview_rex_link); | ||
| const webviewLink = isRex ? bi.webview_rex_link : bi.webview_link; | ||
| const isRex = true; |
There was a problem hiding this comment.
I see that this controls which paths to use but I'm not following why it can always be true
There was a problem hiding this comment.
This is leftover from the transition to Rex. The non-Rex option was CNX, which no longer exists.
There's no longer a webview_link field in the CMS. I need to go through the codebase and remove isRex generally.
All this just to get coverage for one branch in clipped-image.tsx! (But also additional code in TSX with coverage, plus a couple fixes)
RoyEJohnson
force-pushed
the
increase-code-coverage-5
branch
from
c68f782
to
cfa5fcb
Compare
jivey
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISCO-431