-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add persistor to pset components #115
Add persistor to pset components #115
Conversation
Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MReyna12 - This is a partial review of just ProblemSetBlock
and InputProblem
. The reason being, depending on thoughts there it would impact the other components in a similar way. See what you think about my thoughts, but I believe they would address both of the items you raised here:
- Item 1: It would remove the pattern of using state as in the
useEffect
dependencies altogether - Item 2: The
.put()
would get moved intohandleSubmit()
so we could employ the same error handling pattern we have inUserInputBlock
.
@rnathuji - My latest commit addresses your comments. I am still trying to see if there is anything that can be done in the submit handler to not effectively write the same try/catch statement three times (unless you think it is not necessary). Once these updates get approval I will make similar updates to the other components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MReyna12 - I think the changes to InputProblem
in general look good and can be replicated across. I don't see an obvious way to avoid the multiple try / catch
statements, and perhaps that's something we can just defer to a future "real" implementation since what you have does address the key pieces. I did have a few comments on the new handleFeedback()
.
No description provided.