-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: workflows hono app #1093
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 21 out of 36 changed files in this pull request and generated 1 suggestion.
Files not reviewed (15)
- apps/workflows/.dockerignore: Language not supported
- apps/workflows/.gitignore: Language not supported
- apps/workflows/Dockerfile: Language not supported
- apps/workflows/package.json: Language not supported
- apps/workflows/tsconfig.json: Language not supported
- apps/server/src/v1/statusReports/update/post.ts: Evaluated as low risk
- apps/server/src/v1/statusReports/post.ts: Evaluated as low risk
- apps/web/src/lib/auth/index.ts: Evaluated as low risk
- apps/web/src/app/(content)/blog/[slug]/page.tsx: Evaluated as low risk
- apps/server/src/v1/statusReportUpdates/post.ts: Evaluated as low risk
- apps/server/src/v1/pageSubscribers/post.ts: Evaluated as low risk
- apps/workflows/src/cron/checker.ts: Evaluated as low risk
- apps/workflows/README.md: Evaluated as low risk
- apps/workflows/src/cron/tinybird.ts: Evaluated as low risk
- apps/workflows/src/env.ts: Evaluated as low risk
apps/workflows/src/cron/emails.ts
Outdated
|
||
for (const user of users) { | ||
if (user.email) { | ||
await email.sendFollowUp({ to: "[email protected]" }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The email is being sent to a hardcoded address. It should be sent to the user's email address.
await email.sendFollowUp({ to: "[email protected]" }); | |
await email.sendFollowUp({ to: user.email }); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mxkaske name and shame by copilot 🤣
import readline from "node:readline"; | ||
|
||
// Function to prompt user for confirmation | ||
const askConfirmation = async (question: string): Promise<boolean> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it's the script to delete old data?
Can't we move it to a directory script or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could run that on cron e.g.! Let's keep it there for now and consider creating a @openstatus/scripts
package?
import { Resend } from "resend"; | ||
import { FollowUpEmail } from "../emails/followup"; | ||
|
||
export class EmailClient { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOP when most of our codebase is functional 🤔
No description provided.