Actually save things. See #452

openstate · Jan 24, 2024 · 54df2c6 · 54df2c6
1 parent 9c25261
commit 54df2c6
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/ocd_backend/extractors/__init__.py b/ocd_backend/extractors/__init__.py
@@ -47,12 +47,14 @@ def check_if_most_recent(self, provider, site_name, id, report_dict):
         old_item = self.session.query(ItemHash).filter(ItemHash.item_id == item_id).first()
         if old_item:
             old_item.item_hash = new_hash
-            self.session.commit()
+        new_item = ItemHash(item_id=item_id, item_hash=new_hash)
+        self.session.add(new_item)
+        self.session.commit()
+        self.session.flush()
+        if old_item:
             return (old_item.item_hash == new_hash)
         else:
-            new_item = ItemHash(item_id=item_id, item_hash=new_hash)
-            self.session.commit()
-            return True
+            return False
 
     def run(self):
         """Starts the extraction process.