Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some rules for crd schema check #22

Conversation

cescgina
Copy link
Contributor

NoFieldRemoval and NoNewRequiredFields need to be temporarily disabled
since we're currently building the crds as we go.
ConditionsMustHaveProperSSATags and ListsMustHaveSSATags are disabled
beacuse they affect the Conditions type defined in lib-common, so they
are not specific to watcher-operator.

NoFieldRemoval and NoNewRequiredFields need to be temporarily disabled
since we're currently building the crds as we go.
ConditionsMustHaveProperSSATags and ListsMustHaveSSATags are disabled
beacuse they affect the Conditions type defined in lib-common, so they
are not specific to watcher-operator.
@amoralej
Copy link
Contributor

/approve
I'm not sure how practical this job will be in future, but at this point I think the best we can do is to add those exceptions and remove them once we are at a more stable development phase

Copy link

openshift-ci bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amoralej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@SeanMooney SeanMooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, we discussed this and agreed that while we are creating the initial crds and we have not released we want to have less strict crd checking as we are not providing a stable API currently.

for now we will disable the problematic rule and review this again as the CRDs stablise

@openshift-ci openshift-ci bot added the lgtm label Nov 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5f77b5f into openstack-k8s-operators:main Nov 29, 2024
6 checks passed
@cescgina cescgina deleted the disable_rules_crd_schema_check branch November 29, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants