Create reconcilers consistently from watcher_common and add timeout #12
+112
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is implementing a mechanism to create the reconcilers consistently similar to the one used in nova-operator. It is also including a RequeueTimeout parameter which can be used in the lower level calls to avoid that controller gets blocked at some point.
Replace WaitForDBCreate by WaitForDBCreatedWithTimeout and pass the timeout from the RequeueTimeout reconciler parameter.
SeanMooney
reviewed
Nov 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ae46d00
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implementing a mechanism to create the reconcilers consistently similar to the one used in nova-operator.
It is also including a RequeueTimeout parameter which can be used in the lower level calls to avoid that controller gets blocked at some point.
This PR is also implementing this timeout when waiting for the DB to be created.