Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controller manager label #11

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

raukadah
Copy link
Contributor

In all the openstack-operators, openstack.org/operator-name label is used. The same needs to be used in watcher-operator. Otherwise During log collection, ci-framework env_op_images role fails while querying all controller manager pods.

This pr adds openstack.org/operator-name: watcher label to the operator.

Copy link

openshift-ci bot commented Nov 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

In all the openstack-operators, openstack.org/operator-name label is
used. The same needs to be used in watcher-operator. Otherwise During
log collection, ci-framework env_op_images role fails while querying
all controller manager pods.

This pr adds openstack.org/operator-name: watcher label to the operator.

Signed-off-by: Chandan Kumar <[email protected]>
Copy link

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raukadah raukadah marked this pull request as ready for review November 25, 2024 14:37
@openshift-ci openshift-ci bot requested a review from dprince November 25, 2024 14:37
@openshift-merge-bot openshift-merge-bot bot merged commit 26b1967 into openstack-k8s-operators:main Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants