Use new nad.EnsureNetworksAnnotation() func to get NAD annotations

[stuggi]

For BGP setup there is the need to set the default gateway to the additional interface defined via the multus annotations. To allow this a user can configure ipam.gateway in the NAD. EnsureNetworksAnnotation() will override the pod network default route by reading the NAD. If ipam.gateway is defined and not "", it gets set on the networks annotation as the default-route.

Jira: https://issues.redhat.com/browse/OSPRH-8680

Depends-On: openstack-k8s-operators/lib-common#579

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bc643614623e45bb868233cec42bb0dc

✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 17m 21s
❌ podified-multinode-edpm-deployment-crc-test-operator TIMED_OUT in 3h 11m 51s

[stuggi]

/retest

[stuggi]

recheck

[lpiwowar]

@stuggi, the job previously failed on: no kind is registered for the type v1.NetworkAttachmentDefinition in scheme \"go/pkg/mod/k8s.io/[email protected]/pkg/runtime/scheme.go:100\"

2024-11-13T17:18:36Z	ERROR	Reconciler error	{"controller": "tempest", "controllerGroup": "test.openstack.org", "controllerKind": "Tempest", "Tempest": {"name":"tempest-tests","namespace":"openstack"}, "namespace": "openstack", "name": "tempest-tests", "reconcileID": "97582aa0-1531-4fe1-84ae-883bbc64e5bf", "error": "Error getting network-attachment-definition ctlplane/openstack - no kind is registered for the type v1.NetworkAttachmentDefinition in scheme \"go/pkg/mod/k8s.io/[email protected]/pkg/runtime/scheme.go:100\""}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227

https://logserver.rdoproject.org/45/245/d549cb3236e38b4ffbd0271ece083f0e38de9cc7/github-check/podified-multinode-edpm-deployment-crc-test-operator/fc3ca3a/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/test-operator-controller-manager-5c9fbbdd8f-pqb72/logs/manager.log

[stuggi]

@stuggi, the job previously failed on: no kind is registered for the type v1.NetworkAttachmentDefinition in scheme \"go/pkg/mod/k8s.io/[email protected]/pkg/runtime/scheme.go:100\"

2024-11-13T17:18:36Z	ERROR	Reconciler error	{"controller": "tempest", "controllerGroup": "test.openstack.org", "controllerKind": "Tempest", "Tempest": {"name":"tempest-tests","namespace":"openstack"}, "namespace": "openstack", "name": "tempest-tests", "reconcileID": "97582aa0-1531-4fe1-84ae-883bbc64e5bf", "error": "Error getting network-attachment-definition ctlplane/openstack - no kind is registered for the type v1.NetworkAttachmentDefinition in scheme \"go/pkg/mod/k8s.io/[email protected]/pkg/runtime/scheme.go:100\""}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227

https://logserver.rdoproject.org/45/245/d549cb3236e38b4ffbd0271ece083f0e38de9cc7/github-check/podified-multinode-edpm-deployment-crc-test-operator/fc3ca3a/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/test-operator-controller-manager-5c9fbbdd8f-pqb72/logs/manager.log

ack, let me check

[stuggi]

@lpiwowar its fixed now. could you review/approve?

[lpiwowar]

/lgtm