Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dns cluster info from lib common get function #560

Conversation

averdagu
Copy link
Contributor

@averdagu averdagu commented Dec 10, 2024

Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators.

Resolves: OSPRH-3627
Depends-on: openstack-k8s-operators/lib-common#580

@openshift-ci openshift-ci bot requested review from lewisdenny and viroel December 10, 2024 12:03
@averdagu averdagu force-pushed the feat/use-dns-get-lib-common branch from 2e8db3d to 383188c Compare December 10, 2024 14:13
Openshift coreDNS creates the domain name using an string
located in dnses.operator.openshift.io. This string can
change in the future, calling lib-common/GetDNSClusterDomain
the responsability of gathering this information correctly
only falls under lib-common intead of all operators.

Resolves: OSPRH-3627
Depends-on: openstack-k8s-operators/lib-common#580
@averdagu averdagu force-pushed the feat/use-dns-get-lib-common branch from 383188c to db8d5f9 Compare December 10, 2024 15:15
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/365a372e01ba4e0a82dc3fbf33fed4ca

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 44s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 59s
✔️ telemetry-operator-multinode-autoscaling-tempest SUCCESS in 1h 16m 25s
telemetry-operator-multinode-default-telemetry FAILURE in 1h 08m 37s
✔️ functional-tests-on-osp18 SUCCESS in 1h 36m 06s (non-voting)
✔️ functional-logging-tests-osp18 SUCCESS in 1h 10m 26s (non-voting)
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 10m 25s (non-voting)
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 12m 40s (non-voting)

@jlarriba
Copy link
Collaborator

/retest

@jlarriba
Copy link
Collaborator

recheck

@jlarriba
Copy link
Collaborator

/retest

Get "https://quay.rdoproject.org/v2/": dial tcp 38.129.56.158:443: i/o timeout

@vyzigold
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: averdagu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d1fc706 into openstack-k8s-operators:main Dec 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants