Add ObservedGeneration to the sub Resources #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch does a few things: - it adds a Status.OservedGeneration to the sub custom resources - it proposes to bump the observedGeneration at the beginning of the reconciliation loop, after we init the conditions - it checks, at the top level, if the ObservedGeneration matches with the metadata.generation assigned to the subCR(s) Signed-off-by: Francesco Pantano <[email protected]>
vyzigold
requested changes
Apr 22, 2024
This patch extends the current ObservedGeneration pattern to the StatefulSets created by aodh and ceilometer controller. Signed-off-by: Francesco Pantano <[email protected]>
Thank you, good catch, I think I fixed all the leftovers at this point |
|
/lgtm |
vyzigold
approved these changes
Apr 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0607c4a
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does a few things:
ObservedGenerationmatches with themetadata.generationassigned to thesubCR(s)before marking the
DeploymentReadyConditionas True