Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use memcached instance #102

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Use memcached instance #102

merged 2 commits into from
Feb 1, 2024

Conversation

cschwede
Copy link
Collaborator

No description provided.

@cschwede cschwede force-pushed the memcached branch 2 times, most recently from a1875b4 to 43acba2 Compare January 30, 2024 11:47
@cschwede cschwede requested a review from fmount January 31, 2024 09:32
fmount
fmount requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a coding perspective, I had a comment related to the request requeue block that should live in the top-level controller (as memcached is a shared element).

README.md Show resolved Hide resolved
controllers/swiftproxy_controller.go Outdated Show resolved Hide resolved
@cschwede
Copy link
Collaborator Author

/test swift-operator-build-deploy-kuttl

@abays
Copy link
Contributor

abays commented Jan 31, 2024

Need to adjust KUTTL tests to account for new MemcachedReadyCondition in the status:

case.go:366: resource Swift:swift-kuttl-tests/swift: .status.conditions: slice length mismatch: 8 != 9

@cschwede
Add support for memcached instance
b29e3c8 
Removing the existing memcached container will
be done in a follow up commit.
@cschwede
Remove memcached container from within Swift pods
106a63d 
No longer needed due to using the cluster memcached instance.
@cschwede cschwede requested a review from fmount February 1, 2024 06:13
@cschwede
Copy link
Collaborator Author

cschwede commented Feb 1, 2024

Need to adjust KUTTL tests to account for new MemcachedReadyCondition in the status:

case.go:366: resource Swift:swift-kuttl-tests/swift: .status.conditions: slice length mismatch: 8 != 9

Thx, fixed as well.

fmount
fmount approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cschwede, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5cc95b7 into openstack-k8s-operators:main Feb 1, 2024
5 checks passed
@cschwede cschwede deleted the memcached branch February 1, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abays abays abays left review comments

@fmount fmount fmount approved these changes

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

Assignees

@fmount fmount

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cschwede @abays @fmount