Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[envtest]Use database helpers from mariadb-operator #82

Merged
merged 1 commit into from
Sep 29, 2023
Merged

[envtest]Use database helpers from mariadb-operator #82

merged 1 commit into from
Sep 29, 2023

Conversation

gibizer
Copy link
Collaborator

@gibizer gibizer commented Sep 28, 2023

This is necessary to remove a dependency cycle from lib-common

@gibizer
Copy link
Collaborator Author

gibizer commented Sep 28, 2023

/hold wait for the deps

@gibizer gibizer mentioned this pull request Sep 28, 2023
Merged
12 tasks
bogdando
bogdando reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gibizer
[envtest]Use database helpers from mariadb-operator
5e5ef9d 
This is necessary to remove a dependency cycle from lib-common
@gibizer gibizer force-pushed the mariadb-test-helper branch from 764986a to 5e5ef9d Compare September 28, 2023 15:55
@gibizer
Copy link
Collaborator Author

gibizer commented Sep 28, 2023

/unhold

@gibizer
Copy link
Collaborator Author

gibizer commented Sep 29, 2023

/test placement-operator-build-deploy-kuttl

Trying to pull quay.io/openstack-k8s-operators/telemetry-operator-bundle:fe2794ad1e8c0693ff10b6943836e0839740115f...
Getting image source signatures
Copying blob sha256:650d3b94bf808a566371712956dad4562cc126562972206d6f05fa555c561fe2
Copying config sha256:95738e491789fe1a880a47736ff4b45e2010b1a372139d0b86ea42e621290a97
Writing manifest to image destination
Storing signatures
--> 95738e49178
[15/22] STEP 1/1: FROM quay.io/openstack-k8s-operators/horizon-operator-bundle:511d89a0e6cc361635f36b93fda04f13e9bbf404 AS horizon-bundle
Trying to pull quay.io/openstack-k8s-operators/horizon-operator-bundle:511d89a0e6cc361635f36b93fda04f13e9bbf404...
error: build error: error creating build container: initializing source docker://quay.io/openstack-k8s-operators/horizon-operator-bundle:511d89a0e6cc361635f36b93fda04f13e9bbf404: too many requests to registry
+ check_build_result openstack-operator-bundle

mrkisaolamb
mrkisaolamb approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@mrkisaolamb mrkisaolamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, mrKisaoLamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gibizer,mrKisaoLamb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 24d3927 into openstack-k8s-operators:main Sep 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdando bogdando bogdando left review comments

@mrkisaolamb mrkisaolamb mrkisaolamb approved these changes

@abays abays Awaiting requested review from abays

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

Assignees

@mrkisaolamb mrkisaolamb

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gibizer @bogdando @mrkisaolamb @openshift-merge-robot