Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update placementapi to use service override #48

Closed
wants to merge 1 commit into from

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Aug 4, 2023

Removes creation of routes. Those get done in the openstack-operator. Via service overrides the openstack-operator customize the services for the endpoints to the desired state specified in the ctlplane CR using externalEndpoints or the service override in the service template.

Jira: OSP-26690

Depends-On: openstack-k8s-operators/lib-common#313

@openshift-ci openshift-ci bot requested review from bogdando and olliewalsh August 4, 2023 14:24
@stuggi
Copy link
Contributor Author

stuggi commented Aug 4, 2023

/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi stuggi requested review from gibizer and abays and removed request for bogdando August 4, 2023 14:39
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 4, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 4, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
@stuggi stuggi force-pushed the handle_ingress branch 2 times, most recently from c88a198 to 52717d7 Compare August 7, 2023 12:57
// APIOverrideSpec to override the generated manifest of several child resources.
type APIOverrideSpec struct {
// Override configuration for the Service created to serve traffic to the cluster.
Service []service.OverrideSpec `json:"service,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i looked at openstack-k8s-operators/lib-common#313 but didnt see where the service orride type is defined.

we probably want to be fairly strict in what can be overrinde if we expose this interface.
for example we likely do not want to allow the names to be modified but perhaps timeouts or service type might be ok

can you point me to the definition of this datastucture.
any change of the filed in this datastucture will eventually require the service operators to rev ther CRD version so i would like to understand what exactly is in this before we add it to the CRD.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this it.

https://github.com/openstack-k8s-operators/lib-common/blob/539f4c7a835b9568087f688a1e3dd8ef91692b37/modules/common/service/types.go#L81-L100

if so i think that is overly broad as it seams to container the core service service spc which would mean any part fo the service could be overridden which is not a maintainable interface.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, right now its label,annotations and the full spec. I kept it for now to be in sync with the rabbitmq operators, but we could e.g. limit the spec to Type, SessionAffinity, loadBalancerSourceRanges, ExternalName, ExternalTrafficPolicy, SessionAffinityConfig, IPFamilyPolicy, LoadBalancerClass and InternalTrafficPolicy

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i would prefer that. what I'm concerned about is an end user changing something that breaks our assumptions like the sector for the pods

stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 7, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 8, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 8, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 8, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 10, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 10, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 11, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 11, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 14, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 14, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 14, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 14, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 17, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 5, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 6, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 7, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 7, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 8, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 11, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 11, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 11, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 12, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 12, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 12, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
@stuggi
Copy link
Contributor Author

stuggi commented Sep 12, 2023

closing in favor of #61

@stuggi stuggi closed this Sep 12, 2023
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 12, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 12, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 14, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 18, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 20, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 20, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 20, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 20, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 21, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 21, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 21, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 22, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 25, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Oct 2, 2023
Creates the route for the placementapi, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/placement-operator#48

Jira: OSP-26690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants