Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0-fr1] Ensure nodeSelector logic is consistent for all operators #268

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #266

/assign olliewalsh

Switch to a pointer for nodeSelector to allow different logic for empty vs unset
There is no need drop empty nodeSelector maps, omitempty already does this
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olliewalsh
Copy link
Contributor

/test placement-operator-build-deploy

@olliewalsh
Copy link
Contributor

/override ci/prow/placement-operator-build-deploy ci/prow/placement-operator-build-deploy-kuttl
will create follow-up DNM PRs to test as there is a circular dependency with the openstack-operator patch

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

@olliewalsh: Overrode contexts on behalf of olliewalsh: ci/prow/placement-operator-build-deploy, ci/prow/placement-operator-build-deploy-kuttl

In response to this:

/override ci/prow/placement-operator-build-deploy ci/prow/placement-operator-build-deploy-kuttl
will create follow-up DNM PRs to test as there is a circular dependency with the openstack-operator patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ad42d8c into openstack-k8s-operators:18.0-fr1 Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants