Wait for DB writes to propagate (causality checks) #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we deploy the database in multi-master mode we can have cases where reading data from the DB fails after the data was written to another galera master node. We only saw issues happening in nova but we need strict consistency during writing resource allocations to placement. In this patch we change the default value on the DB engine to wait for previous write to sync before read. This will have a performance impact. We use `mysql_wsrep_sync_wait` from oslo.db [1] setting it to 1 as per the documented values of this parameter in the DBMS [2][3]. [1]: https://opendev.org/openstack/oslo.db/commit/009d23df45969036c70e4cf59eb4019aaace9a55 [2]: https://mariadb.com/docs/server/ref/mdb/system-variables/wsrep_sync_wait/ [3]: https://galeracluster.com/library/documentation/mysql-wsrep-options.html Related: https://issues.redhat.com/browse/OSPRH-7198
gibizer
requested review from
mrkisaolamb
and removed request for
olliewalsh and
abays
SeanMooney
approved these changes
May 29, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a5b0bf4
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we deploy the database in multi-master mode we can have cases
where reading data from the DB fails after the data was written to
another galera master node.
We only saw issues happening in nova but we need strict consistency
during writing resource allocations to placement.
In this patch we change the default value on the DB engine to wait for
previous write to sync before read.
This will have a performance impact.
We use
mysql_wsrep_sync_waitfrom oslo.db 1 setting it to 1 as perthe documented values of this parameter in the DBMS 2.
Related: https://issues.redhat.com/browse/OSPRH-7198