Updates to avoid CVE's #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids using the logger from prometheus/common and instead uses the controller-runtime setup logger instead
bogdando
reviewed
Dec 13, 2021
go.mod
Outdated
| sigs.k8s.io/controller-runtime v0.9.7 | ||
| sigs.k8s.io/yaml v1.2.0 | ||
| ) | ||
|
|
||
| replace ( | ||
| // required by Microsoft/hcsshim, containers/storage, sriov-network-operator | ||
| // Not used within this Operator. | ||
| // Bump to avoid CVE detection with v1.5.4. https://bugzilla.redhat.com/show_bug.cgi?id=1899487, https://bugzilla.redhat.com/show_bug.cgi?id=1982681 |
There was a problem hiding this comment.
"with 1.5.4" - is prolly a typo meant to be some older version?
There was a problem hiding this comment.
@bogdando good eye. just pushed a follow up patch to update/fix this comment. Thanks
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dprince
added a commit
to dprince/osp-director-operator
that referenced
this pull request
Dec 15, 2021
* go.mod updates for security and CVEs * Bump CDI and github.com/ulikunitz * Drop prometheus/common dependency This avoids using the logger from prometheus/common and instead uses the controller-runtime setup logger instead * Bump miekg/dns * Correct CVE comment for containerd
dprince
added a commit
that referenced
this pull request
Dec 15, 2021
* go.mod updates for security and CVEs * Bump CDI and github.com/ulikunitz * Drop prometheus/common dependency This avoids using the logger from prometheus/common and instead uses the controller-runtime setup logger instead * Bump miekg/dns * Correct CVE comment for containerd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.