[validation] check glanceAPI names are valid #955
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, gibizer, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/b9b15a1daf51423ab5338b343b263809 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 29m 09s |
|
New changes are detected. LGTM label has been removed. |
|
rebased |
The glanceAPI controller creates StatefulSet for glanceapi to run. This adds a StatefulSet pod's label "controller-revision-hash": "<statefulset_name>-<hash>" to the pod. The kubernetes label is restricted under 63 char and the revision hash is an int32, 10 chars + the hyphen. Which results in a default statefulset max len of 52 chars. The statefulset name also contain the glance name and the glanceAPI type + 2 hyphens. So the max len also need to be reduced bye the length of those. Also the name of the created rabbitmq instance must match a lowercase RFC 1123. Depends-On: openstack-k8s-operators/lib-common#532 Depends-On: openstack-k8s-operators/glance-operator#587 Jira: https://issues.redhat.com/browse/OSPRH-8063 Signed-off-by: Martin Schuppert <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
once more a rebase |
|
/test openstack-operator-build-deploy-kuttl |
openshift-merge-bot
bot
merged commit dfdde79
into
openstack-k8s-operators:main
The glanceAPI controller creates StatefulSet for glanceapi to run. This adds a StatefulSet pod's label
"controller-revision-hash": "<statefulset_name>-" to the pod.
The kubernetes label is restricted under 63 char and the revision hash is an int32, 10 chars + the hyphen. Which results in a default statefulset max len of 52 chars. The statefulset name also contain the glance name and the glanceAPI type + 2 hyphens. So the max len also need to be reduced bye the length of those.
Also the name of the created rabbitmq instance must match a lowercase RFC 1123.
Depends-On: openstack-k8s-operators/lib-common#532
Depends-On: openstack-k8s-operators/glance-operator#587
Jira: https://issues.redhat.com/browse/OSPRH-8063