Move the tempest var to test_operator #738

raukadah · 2024-04-09T12:38:55Z

Since we are already test_operator in all the edpm jobs.Let's use it here also.

Note: it also includes a workaround for https://issues.redhat.com/browse/OSPCIX-487

kopecmartin · 2024-04-09T12:48:13Z

zuul.d/projects.yaml

@@ -6,8 +6,8 @@
    vars:
      cifmw_operator_build_golang_ct: "docker.io/library/golang:1.20"
      cifmw_operator_build_golang_alt_ct: "quay.rdoproject.org/openstack-k8s-operators/golang:1.20"
-      cifmw_tempest_tempestconf_profile:
-          overrides:
+      cifmw_test_operator_tempest_config:


this doesn't seem right, you want to replace the variable meant for tempestconf, but cifmw_test_operator_tempest_config is the config for the whole operator, see it's default:
https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/test_operator/defaults/main.yml#L45

Done, the correct var is cifmw_tempest_tempestconf_config.

lpiwowar · 2024-04-09T14:54:14Z

zuul.d/projects.yaml

@@ -21,14 +21,14 @@
            # tempest gets configured with adminURL and that causes test
            # instability.
            identity.v3_endpoint_type: public
-      cifmw_tempest_tests_allowed:
+      cifmw_test_operator_tempest_include_list:


Both include and exclude list accept strings not list:)

cifmw_test_operator_tempest_include_list: | tempest.scenario tempest.scenario.test_minimum_basic.TestMinimumBasicScenario

lpiwowar · 2024-04-09T14:55:00Z

zuul.d/projects.yaml

-      cifmw_tempest_tempestconf_profile:
-          overrides:
+      cifmw_tempest_tempestconf_config:
+          overrides: |
            compute-feature-enabled.vnc_console: true


The correct syntax is without the colon:

compute-feature-enabled.vnc_console true

lpiwowar · 2024-04-09T14:55:33Z

zuul.d/projects.yaml

      # NOTE(gibi): enable only the high level scenario tests to keep the
      # job run time reasonable
        - tempest.scenario
      # Plus an extra live migration test until we have cinder volumes / ceph
      # to run the live migration scenario tests with it
        - tempest.api.compute.admin.test_live_migration.LiveAutoBlockMigrationV225Test
-      cifmw_tempest_tests_skipped:
+      cifmw_test_operator_tempest_exclude_list:


softwarefactory-project-zuul · 2024-04-09T17:13:31Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6418185b6e134656ac2b685e111c1e22

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 25s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 51s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 10s
❌ openstack-operator-tempest-multinode FAILURE in 1h 19m 40s

softwarefactory-project-zuul · 2024-04-10T00:56:18Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3dc75d792af9463dbd9042ee953d5c8f

✔️ openstack-k8s-operators-content-provider SUCCESS in 31m 23s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 10m 43s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 2m 41s
❌ openstack-operator-tempest-multinode RETRY_LIMIT in 12m 42s

raukadah · 2024-04-10T05:27:34Z

recheck

softwarefactory-project-zuul · 2024-04-10T07:21:37Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9e49635e40f34d9aad51c0436a66043b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 03s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 18s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 16m 17s
❌ openstack-operator-tempest-multinode FAILURE in 1h 34m 17s

karelyatin · 2024-09-18T06:34:01Z

zuul.d/jobs.yaml

+        tempest.api.compute.admin.test_live_migration.LiveAutoBlockMigrationV225Test.test_live_block_migration_with_attached_volume
+      # Note(Chandan): Drop it once https://issues.redhat.com/browse/OSPCIX-487 fixes
+      cifmw_test_operator_tempest_extra_rpms:
+        - python3-testscenarios


for this to work we need to have rdo repos setup in container images, which i think we don't

can try with url instead https://trunk.rdoproject.org/centos9-antelope/deps/latest/noarch/python3-testscenarios-0.5.0-21.el9s.noarch.rpm

karelyatin · 2024-09-18T06:49:36Z

Let's get it in if the CI passes, workaround can be reverted once we have a new promotion with tempest fix included

softwarefactory-project-zuul · 2024-09-18T08:53:07Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4d4c7b8080bb41a1a7e6b696a32f0891

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 49s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 45s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 23m 58s
❌ openstack-operator-tempest-multinode FAILURE in 1h 31m 29s

karelyatin · 2024-09-18T09:09:29Z

zuul.d/jobs.yaml

+          # while cinder/nova is not configured to talk to barbican
+          # re-enable this when that support is added
+          # NOTE(gibi): This is a WA to force the publicURL as otherwise
+          # tempest gets configured with adminURL and that causes test


as moving to test operator would also need to add for mtu test to pass
cifmw_test_operator_tempest_network_attachments:
- ctlplane

softwarefactory-project-zuul · 2024-09-19T01:50:05Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 738,10843d2d47294a2b1b587aad5a37be944ce5b58c

softwarefactory-project-zuul · 2024-09-19T02:39:13Z

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/openstack-operator on branch main. The
problem was:

while scanning a block scalar
in "openstack-k8s-operators/openstack-operator/zuul.d/jobs.yaml@main", line 53, column 1
did not find expected comment or line break
in "openstack-k8s-operators/openstack-operator/zuul.d/jobs.yaml@main", line 53, column 2

Since we are already test_operator in all the edpm jobs. Let's use it here also. Signed-off-by: Chandan Kumar (raukadah) <[email protected]>

lpiwowar

Overall looks good to me 👍

https://logserver.rdoproject.org/38/738/48a99073afd8be31bb5995a403981ff8582e1d99/github-check/openstack-operator-tempest-multinode/69d8fce/controller/ci-framework-data/tests/test_operator/tempest-tests/stestr_results.html

lpiwowar · 2024-09-19T07:24:50Z

zuul.d/jobs.yaml

+        tempest.scenario.test_server_volume_attachment.TestServerVolumeAttachmentScenario
+        tempest.scenario.test_instances_with_cinder_volumes.TestInstancesWithCinderVolumes
+        tempest.api.compute.admin.test_live_migration.LiveAutoBlockMigrationV225Test.test_live_block_migration_with_attached_volume
+        # TODO (rlandy) remove when https://issues.redhat.com/browse/OSPCIX-126 is fixed


I'm just wondering when whether we want to unskip this test since the linked ticked is fixed.

fao89 · 2024-09-19T09:07:31Z

/approve

openshift-ci · 2024-09-19T09:07:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, lpiwowar, raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [fao89]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from frenzyfriday and viroel April 9, 2024 12:39

raukadah force-pushed the test_operator branch 2 times, most recently from 79a57f0 to 2541659 Compare April 9, 2024 12:46

raukadah requested a review from lpiwowar April 9, 2024 12:47

raukadah force-pushed the test_operator branch from 2541659 to b3f0a0d Compare April 9, 2024 12:47

kopecmartin reviewed Apr 9, 2024

View reviewed changes

raukadah force-pushed the test_operator branch from b3f0a0d to d1d88f4 Compare April 9, 2024 12:52

lpiwowar reviewed Apr 9, 2024

View reviewed changes

olliewalsh force-pushed the test_operator branch from d1d88f4 to 3d10e44 Compare April 10, 2024 00:23

olliewalsh requested review from kopecmartin and lpiwowar April 10, 2024 00:24

openshift-merge-robot added the needs-rebase label Apr 12, 2024

raukadah force-pushed the test_operator branch from 3d10e44 to 071b60c Compare September 18, 2024 06:21

openshift-merge-robot removed the needs-rebase label Sep 18, 2024

karelyatin reviewed Sep 18, 2024

View reviewed changes

raukadah force-pushed the test_operator branch from 071b60c to 3a5c507 Compare September 18, 2024 06:39

karelyatin reviewed Sep 18, 2024

View reviewed changes

raukadah force-pushed the test_operator branch from 3a5c507 to 10843d2 Compare September 19, 2024 01:49

openshift-merge-robot added the needs-rebase label Sep 19, 2024

raukadah force-pushed the test_operator branch from 10843d2 to 6fe8e5b Compare September 19, 2024 02:39

openshift-merge-robot removed the needs-rebase label Sep 19, 2024

Move the tempest var to test_operator

48a9907

Since we are already test_operator in all the edpm jobs. Let's use it here also. Signed-off-by: Chandan Kumar (raukadah) <[email protected]>

raukadah force-pushed the test_operator branch from 6fe8e5b to 48a9907 Compare September 19, 2024 02:54

lpiwowar approved these changes Sep 19, 2024

View reviewed changes

openshift-ci bot assigned lpiwowar Sep 19, 2024

openshift-ci bot added the lgtm label Sep 19, 2024

openshift-ci bot added the approved label Sep 19, 2024

openshift-merge-bot bot merged commit aadcf92 into openstack-k8s-operators:main Sep 19, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move the tempest var to test_operator #738

Move the tempest var to test_operator #738

raukadah commented Apr 9, 2024 •

edited

Loading

kopecmartin Apr 9, 2024

raukadah Apr 9, 2024

lpiwowar Apr 9, 2024

lpiwowar Apr 9, 2024

lpiwowar Apr 9, 2024

softwarefactory-project-zuul bot commented Apr 9, 2024

softwarefactory-project-zuul bot commented Apr 10, 2024

raukadah commented Apr 10, 2024

softwarefactory-project-zuul bot commented Apr 10, 2024

karelyatin Sep 18, 2024 •

edited

Loading

karelyatin commented Sep 18, 2024

softwarefactory-project-zuul bot commented Sep 18, 2024

karelyatin Sep 18, 2024

softwarefactory-project-zuul bot commented Sep 19, 2024

softwarefactory-project-zuul bot commented Sep 19, 2024

lpiwowar left a comment

lpiwowar Sep 19, 2024

fao89 commented Sep 19, 2024

openshift-ci bot commented Sep 19, 2024

Move the tempest var to test_operator #738

Move the tempest var to test_operator #738

Conversation

raukadah commented Apr 9, 2024 • edited Loading

kopecmartin Apr 9, 2024

Choose a reason for hiding this comment

raukadah Apr 9, 2024

Choose a reason for hiding this comment

lpiwowar Apr 9, 2024

Choose a reason for hiding this comment

lpiwowar Apr 9, 2024

Choose a reason for hiding this comment

lpiwowar Apr 9, 2024

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Apr 9, 2024

softwarefactory-project-zuul bot commented Apr 10, 2024

raukadah commented Apr 10, 2024

softwarefactory-project-zuul bot commented Apr 10, 2024

karelyatin Sep 18, 2024 • edited Loading

Choose a reason for hiding this comment

karelyatin commented Sep 18, 2024

softwarefactory-project-zuul bot commented Sep 18, 2024

karelyatin Sep 18, 2024

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Sep 19, 2024

softwarefactory-project-zuul bot commented Sep 19, 2024

lpiwowar left a comment

Choose a reason for hiding this comment

lpiwowar Sep 19, 2024

Choose a reason for hiding this comment

fao89 commented Sep 19, 2024

openshift-ci bot commented Sep 19, 2024

raukadah commented Apr 9, 2024 •

edited

Loading

karelyatin Sep 18, 2024 •

edited

Loading