Flatten telemetry resources #574
Conversation
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Hi @paramite. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
paramite
force-pushed
the
telemetry-flattening
branch
from
f364e40 to
0e48086
Compare
|
/ok-to-test |
|
I think this will require KUTTL changes as well, since we reference Ceilometer there. |
|
True, will fix it. |
|
in general PR looks good to me. Fix the pre-commit and kuttl and we should be good to go here |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/939dd65a72e548fa8907fedb70afd05a ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 34m 51s |
jlarriba
force-pushed
the
telemetry-flattening
branch
2 times, most recently
from
5649c21 to
f0def21
Compare
|
I dont know what happens, the precommit check should be working fine, as I pushed the manifests after "make manifests". If I download the patch, the pre-commit check passes succesfully in my env. |
| @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| controller-gen.kubebuilder.io/version: v0.11.1 | |||
| controller-gen.kubebuilder.io/version: v0.10.0 | |||
There was a problem hiding this comment.
@jlarriba I think these are the problem for precommit. We need to run make manifests with the newer version of controller-gen and push that to the PR.
jlarriba
force-pushed
the
telemetry-flattening
branch
from
f0def21 to
abc06c6
Compare
abays
requested review from
dprince
and removed request for
lewisdenny and
frenzyfriday
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/d24e7c100c134e08946448443c788463 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 29m 02s |
This patch replaces Ceilometer resource with Telemetry resouse to avoid adding Autoscaling resource. The Telemetry resource is deploying both Ceilometer and Autoscaling resources and will deploy also Logging resource in future.
paramite
force-pushed
the
telemetry-flattening
branch
from
abc06c6 to
c819e02
Compare
|
Sorry for the delay. Now it should be mergable. |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/7363ffa750cb49b9a9e3acef80710c7d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 28m 09s |
|
recheck |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, paramite The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1773f49
into
openstack-k8s-operators:main
This patch replaces Ceilometer resource with Telemetry resouse to avoid adding Autoscaling resource. The Telemetry resource is deploying both Ceilometer and Autoscaling resources and will deploy also Logging resource in future.