-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crd-schema-check: allow new CRDs #1218
crd-schema-check: allow new CRDs #1218
Conversation
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ff3d3130dbc44c73b75ce5b3f66747e5 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 47s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dprince Thanks for fixing. This was an oversight on my part. I agree that if the base version does not have the CRD defined then the CRD is not a subject of any backward compatibility issues
pre-commit failures are relevant
|
If the 'git show BASE_REF' fails assume it is a net new CRD and should be fine.
f29f78b
to
a8ef410
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, gibizer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/test openstack-operator-build-deploy-kuttl |
703dcaf
into
openstack-k8s-operators:main
If the 'git show BASE_REF' fails assume it is a net new CRD and should be fine.