Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crd-schema-check: allow new CRDs #1218

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Dec 2, 2024

If the 'git show BASE_REF' fails assume it is a net new CRD and should be fine.

@openshift-ci openshift-ci bot requested review from fao89 and viroel December 2, 2024 18:56
@openshift-ci openshift-ci bot added the approved label Dec 2, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ff3d3130dbc44c73b75ce5b3f66747e5

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 47s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 52s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 36s
openstack-operator-tempest-multinode RETRY_LIMIT in 7m 28s

Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dprince Thanks for fixing. This was an oversight on my part. I agree that if the base version does not have the CRD defined then the CRD is not a subject of any backward compatibility issues

@gibizer
Copy link
Contributor

gibizer commented Dec 3, 2024

pre-commit failures are relevant

bashate..................................................................Failed
- hook id: bashate
- exit code: 1
hack/crd-schema-checker.sh:20:1: E003 Indent not multiple of 4
hack/crd-schema-checker.sh:20:1: E003 Indent not multiple of 4
hack/crd-schema-checker.sh:20:1: E003 Indent not multiple of 4
3 bashate error(s) found

If the 'git show BASE_REF' fails assume it is a net new CRD
and should be fine.
@dprince dprince force-pushed the schema_check_fix_new_crds branch from f29f78b to a8ef410 Compare December 3, 2024 12:10
@openshift-ci openshift-ci bot removed the lgtm label Dec 3, 2024
@openshift-ci openshift-ci bot added the lgtm label Dec 3, 2024
Copy link
Contributor

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, gibizer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dprince
Copy link
Contributor Author

dprince commented Dec 3, 2024

/test openstack-operator-build-deploy-kuttl

@openshift-merge-bot openshift-merge-bot bot merged commit 703dcaf into openstack-k8s-operators:main Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants