-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dns cluster info from lib common get function #1215
Use dns cluster info from lib common get function #1215
Conversation
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0da1f9d35f0345e086a7edfb373242aa ❌ openstack-k8s-operators-content-provider FAILURE in 8m 59s |
e05e973
to
f4d648b
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4a733607188d4abf811f69246e946070 ❌ openstack-k8s-operators-content-provider FAILURE in 11m 18s |
b8ad389
to
519166c
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/669413a6148b4de08036a9258b5ed732 ❌ openstack-k8s-operators-content-provider FAILURE in 8m 38s |
519166c
to
eeba792
Compare
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Depends-on: openstack-k8s-operators/lib-common#580 Resolves: OSPRH-3627
eeba792
to
995b36f
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: averdagu, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
68357b2
into
openstack-k8s-operators:main
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators.
Depends-on: openstack-k8s-operators/lib-common#580
Related-Issue: OSPRH-3627