Reapply "[ovn-controller] Don't create ovn-controller if nicMappings" #1104
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/35784b204bcc4f0fbe05418d765a9550 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 09m 14s |
averdagu
changed the title
|
recheck |
…empty" This reverts commit ba9d53e. This commit was reverted the first time as it broke the adoption gates since a config map needed by edpm deployment was not being generated by ovn-controller. This is fixed on ovn-operator PR#352, hence this commit can be reverted. Depends-on: openstack-k8s-operators/ovn-operator#352
averdagu
force-pushed
the
feat/nicMappings
branch
from
3152494 to
cbbc2ef
Compare
|
The patch is ok but we'll need to wait for the ovn-operator part to land first. |
|
|
/retest-required |
|
Kuttl tests failed with: |
|
/retest-required |
|
FYI |
| name: openstack | ||
| commands: | ||
| - script: | | ||
| oc delete --ignore-not-found=true -n $NAMESPACE pvc \ |
There was a problem hiding this comment.
nit: this wrapping is weird :)
|
The latest run at https://review.rdoproject.org/r/c/testproject/+/54746 is green and confirms this PR no longer breaks adoption gate (after Arnau moved -config generation to OVNDbCluster controller). |
|
This looks good for me and we should be good to go with it now |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: averdagu, booxter, fao89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Again, |
|
/retest-required |
|
/retest-required |
openshift-merge-bot
bot
merged commit 50a00b9
into
openstack-k8s-operators:main
This is the same patch that was merged a couple of days ago (seen on PR#1070).
This commit blocked adoption gates so it got reverted (on PR#1103), more
information about problem on the description.
Recreating PR to be able to test changes done in ovn-operator (PR#352) while
we fix the error uncover with this patch.
Depends-on: openstack-k8s-operators/ovn-operator#352
#1070
#1103
openstack-k8s-operators/ovn-operator#352