Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop EEJobInterface #1088

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Drop EEJobInterface #1088

merged 1 commit into from
Sep 24, 2024

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Sep 20, 2024

It's not used anywhere. If we've multiple structs implementing the same methods, we can have an interface and call the methods on the interface.

@openshift-ci openshift-ci bot requested review from bshephar and viroel September 20, 2024 04:44
@rabi rabi changed the title Drop EEInterface Drop EEJobInterface Sep 20, 2024
@rabi rabi force-pushed the interface branch 2 times, most recently from f414569 to 0cdc90a Compare September 20, 2024 05:55
@rabi
Copy link
Contributor Author

rabi commented Sep 20, 2024

/test openstack-operator-build-deploy-kuttl

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/95446dc101a44acf8d764214bc3f8040

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 58m 06s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 40m 38s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 42m 40s
❌ openstack-operator-tempest-multinode FAILURE in 1h 45m 16s

@rabi
Drop EEInterface
ccf6020 
It's not used anywhere. If we've multiple structs implementing the
same methods, we can have an interface and call the methods on the
interface.

Also adds call to addEnvFrom().

Signed-off-by: rabi <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/36ffaf3ff7874892a96f0e9d9f733b7b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 10s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 05s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 08s
❌ openstack-operator-tempest-multinode FAILURE in 1h 37m 08s

@rabi
Copy link
Contributor Author

rabi commented Sep 22, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7c4fa79a1659443aa975969ff5757389

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 51s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 23s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 25m 03s
❌ openstack-operator-tempest-multinode FAILURE in 1h 36m 52s

@rabi
Copy link
Contributor Author

rabi commented Sep 23, 2024

recheck RETRY_LIMIT

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/76fe7eeaa6b4471bbb7858ee4e660d27

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 48s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 43s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 24m 01s
❌ openstack-operator-tempest-multinode FAILURE in 1h 38m 55s

@openshift-ci openshift-ci bot added the lgtm label Sep 23, 2024
@jpodivin
Copy link
Contributor

recheck

Openshift marketplace failure Some core CRC pods are not ready...

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6f87dda765d445a1a566e9981ca91d10

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 43s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 12s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 21m 54s
❌ openstack-operator-tempest-multinode FAILURE in 1h 35m 44s

@jpodivin
Copy link
Contributor

Tempest test:
testtools.matchers._impl.MismatchError: 'compute-2.ctlplane.example.com' != 'compute-1.ctlplane.example.com': Live Migration failed. Migrations list for Instance 1fb75314-c0fa-46d4-a74c-46fd594e7804

https://logserver.rdoproject.org/88/1088/ccf6020aaeedd50bc3e4d3d209ef67ee4d19f232/github-check/openstack-operator-tempest-multinode/a5c8f4a/controller/ci-framework-data/tests/test_operator/tempest-tests/stestr_results.html

@jpodivin jpodivin mentioned this pull request Sep 23, 2024
Open
bshephar
bshephar approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@bshephar bshephar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was thinking about using it for some tests, but I never ended up implementing it. Should have dropped it from my original PR, my bad.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, jpodivin, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bshephar,jpodivin,rabi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rabi
Copy link
Contributor Author

rabi commented Sep 24, 2024

Yeah, I was thinking about using it for some tests, but I never ended up implementing it. Should have dropped it from my original PR, my bad.

Unless multiple structs implement the same interface, you don't need them. Also, it was hiding the fact that addEnvFrom() is not called at all and linter was not complaining.

@rabi
Copy link
Contributor Author

rabi commented Sep 24, 2024

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit e054da2 into openstack-k8s-operators:main Sep 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpodivin jpodivin jpodivin approved these changes

@bshephar bshephar bshephar approved these changes

@viroel viroel Awaiting requested review from viroel

Assignees

@bshephar bshephar

@jpodivin jpodivin

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rabi @jpodivin @bshephar @openshift-merge-robot