Removing unused control plane default structure and funcs #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpodivin
force-pushed
the
removedefaults
branch
from
16c76bc to
7162a64
Compare
Signed-off-by: Jiri Podivin <[email protected]>
jpodivin
force-pushed
the
removedefaults
branch
from
7162a64 to
78ffe41
Compare
|
/retest
|
|
These probably haven't been used since we added OpenStackVersion |
dprince
approved these changes
Sep 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, jpodivin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e81d756
into
openstack-k8s-operators:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has been implemented a while ago, and we have moved on since then. Contents of the structure weren't actually used to set default values of the resource spec.
Originally I wanted to leave the
SetupDefaultsstub. Although it doesn't do anything right now, there may be a time when we can develop it into something useful. But we can do that anyway, start from scratch.