Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename InstanceHA to InstanceHa and add image to configmap #1065

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

lmiccini
Copy link
Contributor

This commits renames InstanceHA to InstanceHa to adhere to the openstackversion naming (casing) scheme.
It also adds the Infra InstanceHa image to a dedicated configmap so that the infra-operator can watch it and react to changes.

@openshift-ci openshift-ci bot requested review from fao89 and rebtoor September 12, 2024 07:41
@lmiccini lmiccini force-pushed the iha-cm branch 7 times, most recently from 0c50cc3 to 1df486c Compare September 12, 2024 15:04
@lmiccini
Copy link
Contributor Author

/test openstack-operator-build-deploy-kuttl

@lmiccini lmiccini force-pushed the iha-cm branch 3 times, most recently from 81ab4f0 to 3ec7a58 Compare September 13, 2024 07:09
This commits renames InstanceHA to InstanceHa to adhere to the
openstackversion naming (casing) scheme.
It also adds the Infra InstanceHa image to a dedicated configmap
so that the infra-operator can watch it and react to changes.
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmiccini, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ec8d6c5 into openstack-k8s-operators:main Sep 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants