Add ObservedGeneration to the sub Resources #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibizer
reviewed
Apr 9, 2024
fmount
force-pushed
the
conditions
branch
3 times, most recently
from
e4b0d30 to
7891792
Compare
gibizer
reviewed
Apr 17, 2024
This patch does a few things: 1. it adds observedGeneration to the sub custom resources 2. it proposes to bump the observedGeneration at the beginning of the reconciliation loop (knative/serving#4937) 3. it checks, at the top level, if the ObservedGeneration matches with the metadata.generation assigned to the subCR(s), and if it's the last version it mirrors the Conditions 4. before marking the DeploymentReadyCondition as True, the ObservedGeneration is compared with the Generation of the Deployment/DaemonSets Signed-off-by: Francesco Pantano <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, gibizer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit fc90a6f
into
openstack-k8s-operators:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does a few things:
it adds observedGeneration to the sub custom resources
it proposes to bump the observedGeneration at the beginning of the reconciliation loop (metadata.observedGeneration behaves differently across CRDs knative/serving#4937)
it checks, at the top level, if the ObservedGeneration matches with the metadata.generation assigned to the subCR(s)
before marking the DeploymentReadyCondition as True, the ObservedGeneration is compared with the Generation of the Deployment/DaemonSets