Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tlse] tls support for octaviaAPI, amphora pod configuration, add TLS… #265

Merged

Conversation

Deydra71
Copy link
Contributor

… databse connection

Public/Internal service cert secrets and the CA bundle secret can be passed to configure httpd virtual hosts for tls termination. The certs get direct mounted to the appropriate place in etc/pki/tls/certs/%s.crt|key and a CA bundle to /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem . Job deployments for bootstrap/cron get the CA bundle added if configured.

Depends-On: openstack-k8s-operators/lib-common#428

@Deydra71
Copy link
Contributor Author

/retest

@Deydra71
Copy link
Contributor Author

Deydra71 commented Mar 13, 2024

/test octavia-operator-build-deploy-kuttl

@Deydra71
Copy link
Contributor Author

/retest

@Deydra71 Deydra71 force-pushed the tlse-support branch 4 times, most recently from 19ee0f7 to acbb5da Compare March 14, 2024 13:43
{{- end }}

## WSGI configuration
WSGIProcessGroup octavia-wsgi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WSGIProcessGroup {{ $endpt }}

WSGIProcessGroup octavia-wsgi
WSGIApplicationGroup %{GLOBAL}
WSGIPassAuthorization On
WSGIDaemonProcess octavia-wsgi processes=5 threads=1 user=octavia group=octavia display-name=%{GROUP}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WSGIDaemonProcess {{ $endpt }} processes=5 threads=1 user=octavia group=octavia display-name={{ $endpt }}

@Deydra71 Deydra71 force-pushed the tlse-support branch 2 times, most recently from 83dedff to 6df4739 Compare March 15, 2024 08:20
@Deydra71
Copy link
Contributor Author

/retest

@Deydra71
Copy link
Contributor Author

/retest

Failed due to the ovn ImagePullBackOff

@Deydra71
Copy link
Contributor Author

/retest

@Deydra71
Copy link
Contributor Author

Still failing:

Failed pod/ovsdbserver-sb-0 Failed to pull image "quay.io/podified-antelope-centos9/openstack-ovn-sb-db-server@sha256:28eb40cabc392e3b15bf8db8f66874e7c8dacc6228054a0995f087e73d5410ad": rpc error: code = Unknown desc = reading manifest sha256:28eb40cabc392e3b15bf8db8f66874e7c8dacc6228054a0995f087e73d5410ad in quay.io/podified-antelope-centos9/openstack-ovn-sb-db-server: manifest unknown

@Deydra71
Copy link
Contributor Author

/retest

@Deydra71
Copy link
Contributor Author

Deydra71 commented Mar 19, 2024

Failed because of missing volumes and volumeMounts in the TLS assertion file, but CI is working finally ^^
(Octavia scale kuttl passed)

@Deydra71
Copy link
Contributor Author

/retest

@Deydra71
Copy link
Contributor Author

/retest

Error generating bundle manifests: error resolving image: GET https://registry.redhat.io/auth/realms/rhcc/protocol/redhat-docker-v2/auth?scope=repository%3Arhel8%2Fhttpd-24%3Apull&service=docker-registry: unexpected status code 503 Service Unavailable

@Deydra71 Deydra71 force-pushed the tlse-support branch 3 times, most recently from 44f7784 to 1f4da83 Compare March 19, 2024 20:48
@Deydra71
Copy link
Contributor Author

/retest

neutron-db-sync-wp55t image error:
Failed 20m (x6 over 21m) kubelet Error: ImagePullBackOff

Deydra71 added a commit to Deydra71/openstack-operator that referenced this pull request Mar 20, 2024
Creates certs for k8s service of the service operator when spec.tls.endpoint.internal.enabled: true

For a service like nova which talks to multiple service internal endpoints, this has to be set for each of them for, like:

  customServiceConfig: |
    [keystone_authtoken]
    insecure = true
    [placement]
    insecure = true
    [neutron]
    insecure = true
    [glance]
    insecure = true
    [cinder]
    insecure = true
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/octavia-operator#265

Signed-off-by: Veronika Fisarova <[email protected]>
… databse connection

Public/Internal service cert secrets and the CA bundle secret can be passed to configure httpd virtual hosts for tls termination. The certs get direct mounted to the appropriate place in etc/pki/tls/certs/%s.crt|key and a CA bundle to /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem . Job deployments for bootstrap/cron get the CA bundle added if configured.

Depends-On: openstack-k8s-operators/lib-common#428

Signed-off-by: Veronika Fisarova <[email protected]>
@Deydra71
Copy link
Contributor Author

/retest

Kuttl tests themselves passed, connection issue at the end

@gthiemonge
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 26, 2024
@weinimo
Copy link
Collaborator

weinimo commented Mar 26, 2024

/approve
I'll create a new PR about the issues I found.

Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Deydra71, weinimo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7fd1a4f into openstack-k8s-operators:main Mar 26, 2024
5 checks passed
Deydra71 added a commit to Deydra71/openstack-operator that referenced this pull request Mar 27, 2024
Creates certs for k8s service of the service operator when spec.tls.endpoint.internal.enabled: true

For a service like nova which talks to multiple service internal endpoints, this has to be set for each of them for, like:

  customServiceConfig: |
    [keystone_authtoken]
    insecure = true
    [placement]
    insecure = true
    [neutron]
    insecure = true
    [glance]
    insecure = true
    [cinder]
    insecure = true

Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/octavia-operator#265

Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71 added a commit to Deydra71/openstack-operator that referenced this pull request Mar 27, 2024
Creates certs for k8s service of the service operator when spec.tls.endpoint.internal.enabled: true

For a service like nova which talks to multiple service internal endpoints, this has to be set for each of them for, like:

  customServiceConfig: |
    [keystone_authtoken]
    insecure = true
    [placement]
    insecure = true
    [neutron]
    insecure = true
    [glance]
    insecure = true
    [cinder]
    insecure = true

Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/octavia-operator#265
Co-authored-by: [email protected]

Signed-off-by: Veronika Fisarova <[email protected]>
stuggi pushed a commit to stuggi/openstack-operator that referenced this pull request Apr 9, 2024
Creates certs for k8s service of the service operator when spec.tls.endpoint.internal.enabled: true

For a service like nova which talks to multiple service internal endpoints, this has to be set for each of them for, like:

  customServiceConfig: |
    [keystone_authtoken]
    insecure = true
    [placement]
    insecure = true
    [neutron]
    insecure = true
    [glance]
    insecure = true
    [cinder]
    insecure = true

Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/octavia-operator#265
Co-authored-by: [email protected]

Signed-off-by: Veronika Fisarova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants