Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller runtime update #232

Merged
merged 8 commits into from
Feb 15, 2024

Conversation

bshephar
Copy link
Contributor

@bshephar bshephar commented Feb 7, 2024

This changes updates the controller-runtime and fixes the initialisation of objects to comply with the new controller-runtime standards. Namely:

We fix the function signatures of the webhook to include admissions.Warnings:
kubernetes-sigs/controller-runtime@8770b4d

We fix the initialisation of the manager to declare the webhook following the new schema:
kubernetes-sigs/controller-runtime@91cdd8c

We fix the Watches function to comply with the new signature definition:
kubernetes-sigs/controller-runtime@dc62ed5

Add context to EventHandlers:
kubernetes-sigs/controller-runtime@2464a9d

@openshift-ci openshift-ci bot requested review from abays and slawqo February 7, 2024 03:28
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bshephar
Once this PR has been reviewed and has the lgtm label, please assign gthiemonge for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Brendan Shephard <[email protected]>
This change updates the webhook functions to comply with the new
standard for controller-runtime.

Signed-off-by: Brendan Shephard <[email protected]>

webhook test suite fix

Signed-off-by: Brendan Shephard <[email protected]>
This change updates the manager intialisation to comply with the new
controller-runtime schema.

Signed-off-by: Brendan Shephard <[email protected]>
This change fixes the Watches declarations to comply with the new
controller-runtime standards.

Signed-off-by: Brendan Shephard <[email protected]>
Signed-off-by: Brendan Shephard <[email protected]>
Signed-off-by: Brendan Shephard <[email protected]>
Signed-off-by: Brendan Shephard <[email protected]>
Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

@bshephar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/octavia-operator-build-deploy-kuttl 6f86b89 link true /test octavia-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bshephar bshephar merged commit c57a33f into openstack-k8s-operators:main Feb 15, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants