Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cert management #207

Merged

Conversation

weinimo
Copy link
Collaborator

@weinimo weinimo commented Dec 4, 2023

No description provided.

@openshift-ci openshift-ci bot requested review from abays and gthiemonge December 4, 2023 09:13
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: weinimo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 4, 2023
@weinimo
Copy link
Collaborator Author

weinimo commented Dec 4, 2023

/hold change in install_yamls needed first to create secret

@weinimo
Copy link
Collaborator Author

weinimo commented Dec 4, 2023

/retest

@weinimo
Copy link
Collaborator Author

weinimo commented Dec 5, 2023

Needs openstack-k8s-operators/install_yamls#649 to be merged first

@weinimo weinimo requested review from beagles and johnsom December 5, 2023 13:39
@weinimo
Copy link
Collaborator Author

weinimo commented Dec 5, 2023

/hold cancel

@gthiemonge
Copy link
Contributor

/lgtm

the comments will be addressed in a follow up patch

@weinimo
Copy link
Collaborator Author

weinimo commented Dec 12, 2023

/retest connection issue

Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

@weinimo: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test images
  • /test octavia-operator-build-deploy-kuttl
  • /test precommit-check
  • /test unit

The following commands are available to trigger optional jobs:

  • /test octavia-operator-build-deploy

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openstack-k8s-operators-octavia-operator-main-images
  • pull-ci-openstack-k8s-operators-octavia-operator-main-octavia-operator-build-deploy-kuttl
  • pull-ci-openstack-k8s-operators-octavia-operator-main-precommit-check
  • pull-ci-openstack-k8s-operators-octavia-operator-main-unit

In response to this:

/retest connection issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@weinimo
Copy link
Collaborator Author

weinimo commented Dec 12, 2023

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit c143deb into openstack-k8s-operators:main Dec 12, 2023
8 checks passed
@weinimo weinimo mentioned this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants