Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing transport URL config #183

Merged

Conversation

beagles
Copy link
Collaborator

@beagles beagles commented Oct 6, 2023

Recent amphora controller support changes were missing the init.sh and initcontainer changes required for configuring the rabbitmq transport_url.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: beagles

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 6, 2023
@beagles beagles marked this pull request as ready for review October 6, 2023 13:35
@openshift-ci openshift-ci bot requested review from dprince and olliewalsh October 6, 2023 13:35
@beagles beagles force-pushed the fix-missing-transport-url branch from 4cc430b to 03fe9b1 Compare October 6, 2023 13:42
Recent amphora controller support changes were missing the init.sh and
initcontainer changes required for configuring the rabbitmq
transport_url.
@beagles beagles force-pushed the fix-missing-transport-url branch from 03fe9b1 to eeaf9ed Compare October 6, 2023 14:37
@beagles beagles requested review from weinimo and gthiemonge October 9, 2023 20:45
@weinimo
Copy link
Collaborator

weinimo commented Oct 10, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2023
@openshift-ci openshift-ci bot merged commit 821dd87 into openstack-k8s-operators:main Oct 10, 2023
3 checks passed
@beagles beagles deleted the fix-missing-transport-url branch March 1, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants