Use new nad.EnsureNetworksAnnotation() func to get NAD annotations #893
Conversation
stuggi
requested review from
olliewalsh,
lmiccini,
gibizer and
mrkisaolamb
and removed request for
frenzyfriday
|
could you please add a unit test |
we already have unit tests for this when I introduced it initially in https://github.com/openstack-k8s-operators/nova-operator/blob/main/test/functional/novaconductor_controller_test.go#L496 . also we have unit tests in lib-common for the func. |
ok, if we don't need additional coverage for nadList, it looks good then |
For BGP setup there is the need to set the default gateway to the additional interface defined via the multus annotations. To allow this a user can configure `ipam.gateway` in the NAD. EnsureNetworksAnnotation() will override the pod network default route by reading the NAD. If `ipam.gateway` is defined and not "", it gets set on the networks annotation as the `default-route`. Jira: https://issues.redhat.com/browse/OSPRH-8680 Depends-On: openstack-k8s-operators/lib-common#579 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
force-pushed
the
nad_annotation_gw
branch
from
873e91e to
ecbc6d0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrkisaolamb, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b95e933
into
openstack-k8s-operators:main
For BGP setup there is the need to set the default gateway to the additional interface defined via the multus annotations. To allow this a user can configure
ipam.gatewayin the NAD. EnsureNetworksAnnotation() will override the pod network default route by reading the NAD. Ifipam.gatewayis defined and not "", it gets set on the networks annotation as thedefault-route.Jira: https://issues.redhat.com/browse/OSPRH-8680
Depends-On: openstack-k8s-operators/lib-common#579