-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DB purge CronJob #698
Add DB purge CronJob #698
Conversation
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/e23e37eea1df4f6fa3eb5ce8d767e07d ❌ nova-operator-content-provider FAILURE in 11m 37s |
3fb6584
to
7fcaa77
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/f2ee19be261e4bdca52a6a087bfa70b0 ✔️ nova-operator-content-provider SUCCESS in 56m 25s |
9f0dda8
to
4e075f1
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/fbe5f49981fd4f96a7f30ef994f506ab ❌ nova-operator-content-provider FAILURE in 15m 22s |
2e86c5a
to
9476d52
Compare
kuttl failure seems to be unrelated but probably persistent
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/19c4c742400f4105a4ab58b7fe433fc0 ✔️ nova-operator-content-provider SUCCESS in 2h 01m 06s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall i think this looks good. im a little confused why some of the enve tests are suing "1 0 * * *" instead of "0 0 * * *"
@@ -135,6 +136,14 @@ var _ = Describe("Nova controller", func() { | |||
Expect(instance.Status.RegisteredCells).To(BeEmpty()) | |||
}) | |||
|
|||
It("defaults Spec fields", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not really default its the test defaults
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can drop the assert of the schedule filed as that is not the default, but the two age fields are defaults here
the funcitonal test failure is not to contain substring flaky test? or do we need to similate this being ready or something like that to make it work properly? |
probably yes. but the kuttl job is broken on main |
/test functional |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/6be432437726415bb039591b0135768b ✔️ nova-operator-content-provider SUCCESS in 1h 59m 11s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/b06e332b494246ee8d9dd28b94aca4be ✔️ nova-operator-content-provider SUCCESS in 2h 14m 22s |
kuttl test failure is relevant, probably we have a different name in kuttl
|
d403bdb
to
5b568b7
Compare
rebased after memcache support landed |
We will have one CronJob per cell to do db archiving and purging per cell. Pointer types are needed for nested struct field defaulting. Operator-lint update is needed to handle the pointer types properly in the omitempty check and to handle an edge case with generic types. Implements: OSPRH-104
Implements: OSPRH-104
8b76a7b
to
6990025
Compare
kuttl is finally green \o/ |
/test |
@gibizer: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest required |
@gibizer: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
/retest-required |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, mrkisaolamb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6a99bf2
into
openstack-k8s-operators:main
We will have one CronJob per cell to do db archiving and purging per
cell.
Pointer types are needed for nested struct field defaulting.
Operator-lint update is needed to handle the pointer types properly in
the omitempty check and to handle an edge case with generic types.
Implements: OSPRH-104