Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with not verified cert during cleaning #611

Closed
wants to merge 1 commit into from
Closed

Fix issue with not verified cert during cleaning #611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions controllers/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
"crypto/x509"
"fmt"
"net/http"
"net/url"
"sort"
"time"

Expand Down Expand Up @@ -537,12 +538,24 @@ func (r *ReconcilerBase) ensureMetadataDeleted(
func getNovaClient(ctx context.Context,
h *helper.Helper, authURL string, adminUser string, authPassword string, timeout time.Duration) (*gophercloud.ServiceClient, ctrl.Result, error) {

parsedAuthURL, err := url.Parse(authURL)
if err != nil {
return nil, ctrl.Result{}, err
}

tlscfg := &openstack.TLSConfig{}
if parsedAuthURL.Scheme == "https" {
// TODO: (ksambor) for now just set to insecure, when keystone got
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we merge this we need to file an jira bug or gitbub issue to fix this and target it for Q1 if we cant fixt it properly by the end of the year.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is related to https://issues.redhat.com/browse/OSP-19151
so i would like to have a bug that is set as a blocker for that.
the intent is to complete that by the end for q4
@stuggi @olliewalsh does that sound ok to ye ^

// enabled for internal tls, get the CA secret name from the keystoneAPI
tlscfg.Insecure = true
}
cfg := openstack.AuthOpts{
AuthURL: authURL,
Username: adminUser,
Password: authPassword,
DomainName: "Default", // fixme",
Region: "regionOne", // fixme",
TLS: tlscfg,
}
opts := gophercloud.AuthOptions{
IdentityEndpoint: cfg.AuthURL,
Expand Down
Loading