[envtest]Use keystone helpers from keystone-operator #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold this work in progress |
14 tasks
gibizer
force-pushed
the
keystone-test-helper
branch
from
2e753c5 to
4b8895a
Compare
This was necessary to remove a dependency cycle from lib-common
gibizer
force-pushed
the
keystone-test-helper
branch
from
4b8895a to
e0d0bfe
Compare
|
/unhold |
|
you can test that it does not depend on the lib-common keystone helpers any more by adding the following replace and run the test locally. The lib-common hash there is the one that removes the keystone helpers from lib-common (openstack-k8s-operators/lib-common#339) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit c0bb982
into
openstack-k8s-operators:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was necessary to remove a dependency cycle from lib-common