Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update novaapi, novametadata and novanovncproxy to use service override #489

Closed
wants to merge 2 commits into from

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Aug 10, 2023

Removes creation of routes. Those get done in the openstack-operator. Via service overrides the openstack-operator customize the services for the endpoints to the desired state specified in the ctlplane CR using externalEndpoints or the service override in the service template.

Jira: OSP-26690

Depends-On: openstack-k8s-operators/lib-common#313

@openshift-ci openshift-ci bot requested review from jamepark4 and SeanMooney August 10, 2023 15:07
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 10, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
@stuggi stuggi requested review from gibizer and removed request for jamepark4 August 10, 2023 15:13
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/dd435609f3f24b7e8f8aa34d9c0229b6

nova-operator-content-provider FAILURE in 10m 17s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job nova-operator-content-provider

stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 10, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
endpoint.EndpointInternal: {Port: novncproxy.NoVNCProxyPort},
var ports = map[service.Endpoint]endpoint.Data{
service.EndpointPublic: {Port: novncproxy.NoVNCProxyPort},
service.EndpointInternal: {Port: novncproxy.NoVNCProxyPort},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if there is the need for vncproxy to on the internal network. pods should probably be confgured to be attached via multus to the internal api network

stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 11, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 11, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 14, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 14, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 14, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 14, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 14, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
@@ -41,7 +41,7 @@ func CreateNovaCellAndEnsureReady(cell CellNames) {
th.SimulateJobSuccess(cell.CellDBSyncJobName)
th.SimulateStatefulSetReplicaReady(cell.ConductorStatefulSetName)

SimulateNoVNCProxyRouteIngress(cell1.CellName.Name, cell1.CellName.Namespace)
//SimulateNoVNCProxyRouteIngress(cell1.CellName.Name, cell1.CellName.Namespace)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gibizer wondering what you think would be best for the externalcompute getting the vnc endpoint. right now it checks for the route [1], the externalcompute could check the novncproxy CR. either the host/url could be stored in the status, or it could get the endpointURL from the override and take the the novncproxy service.
[1] https://github.com/openstack-k8s-operators/nova-operator/blob/main/controllers/novaexternalcompute_controller.go#L461-L476

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6975d5a38b6f4eabb845f259d21ed1a7

nova-operator-content-provider FAILURE in 7m 55s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job nova-operator-content-provider

stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 15, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Aug 16, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
Removes creation of routes. Those get done in the openstack-operator.
Via service overrides the openstack-operator customize the services
for the endpoints to the desired state specified in the ctlplane CR
using externalEndpoints or the service override in the service template.

Jira: OSP-26690

Depends-On: openstack-k8s-operators/lib-common#313
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/776502422a76444985e14335ffa34d8c

nova-operator-content-provider FAILURE in 12m 18s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job nova-operator-content-provider

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2023

@stuggi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional 1b769dd link true /test functional
ci/prow/nova-operator-build-deploy 1b769dd link false /test nova-operator-build-deploy
ci/prow/nova-operator-build-deploy-tempest 1b769dd link false /test nova-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 5, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 6, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 7, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 7, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 8, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 11, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 11, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 11, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 12, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 12, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 12, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
@stuggi
Copy link
Contributor Author

stuggi commented Sep 12, 2023

closing in favor of #522

@stuggi stuggi closed this Sep 12, 2023
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 12, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 12, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 14, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 18, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 20, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 20, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 20, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 20, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 21, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 21, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 21, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 22, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Sep 25, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Oct 2, 2023
Creates the route for the nova components, also allows to customize the
route via override.

Generats the service override for the env with what is configured in
the externalEndpoints, or specified in the service template override.

Depends-On: openstack-k8s-operators/lib-common#313
Depends-On: openstack-k8s-operators/keystone-operator#289
Depends-On: openstack-k8s-operators/nova-operator#489

Jira: OSP-26690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants