Update k8s.io #224

renovate · 2023-01-12T18:03:52Z

This PR contains the following updates:

Package	Type	Update	Change
k8s.io/api	require	minor	`v0.25.5` -> `v0.26.1`
k8s.io/apimachinery	require	patch	`v0.26.0` -> `v0.26.1`
k8s.io/client-go	require	minor	`v0.25.4` -> `v0.26.1`
sigs.k8s.io/controller-runtime	require	minor	`v0.13.1` -> `v0.14.2`

Release Notes

kubernetes/api

kubernetes/apimachinery

`v0.26.1`

Compare Source

kubernetes/client-go

`v0.26.1`

Compare Source

`v0.26.0`

Compare Source

`v0.25.6`

Compare Source

`v0.25.5`

Compare Source

kubernetes-sigs/controller-runtime

`v0.14.2`

Compare Source

What's Changed

[release-0.14] 🌱 Bump k8s.io/* to v0.26.1 by @sbueringer in https://github.com/kubernetes-sigs/controller-runtime/pull/2146

Full Changelog: kubernetes-sigs/controller-runtime@v0.14.1...v0.14.2

`v0.14.1`

Compare Source

Changes since v0.14.0

🐛 Bug Fixes

🐛 controllers without For() fail to start by @k8s-infra-cherrypick-robot in https://github.com/kubernetes-sigs/controller-runtime/pull/2108

Full Changelog: kubernetes-sigs/controller-runtime@v0.14.0...v0.14.1

`v0.14.0`

Compare Source

Changes since v0.13.1

⚠️ Breaking Changes

Add Get functionality to SubResourceClient (#2094)
Allow configuring RecoverPanic for controllers globally (#2093)
Add client.SubResourceWriter (#2072)
Support registration and removal of event handler (#2046)
Update Kubernetes dependencies to v0.26 (#2043, #2087)
Zap log: Default to RFC3339 time encoding (#2029)
cache.BuilderWithOptions inherit options from caller (#1980)
Migrate to ginkgo v2 (https://github.com/kubernetes-sigs/controller-runtime/pull/1977), this removes the pkg/envtest/printer package

✨ New Features

Builder: Do not require For (#2091)
support disable deepcopy on list funcion (#2076)
Add cluster.NewClientFunc with options (#2054)
Tidy up startup logging of kindWithCache source (#2057)
Add function to get reconcileID from context (#2056)
feat: add NOT predicate (#2031)
Allow to provide a custom lock interface to manager (#2027)
Add tls options to manager.Options (#2023)
Update Go version to 1.19 (#1986)

🐛 Bug Fixes

Prevent manager from getting started a second time (#2090)
Missing error log for in-cluster config (#2051)
Skip custom mutation handler when delete a CR (#2049)
fix: improve semantics of combining cache selectorsByObject (#2039)
Conversion webhook should not panic when conversion request is nil (#1970)

🌱 Others

Prepare for release 0.14 (#2100)
Generate files and update modules (#2096)
Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0 (#2097)
Bump golang.org/x/time (#2089)
Update OWNERS: remove inactive members, promote fillzpp sbueringer (#2088, #2092)
Default ENVTEST version to a working one (1.24.2) (#2081)
Update golangci-lint to v1.50.1 (#2080)
Bump go.uber.org/zap from 1.23.0 to 1.24.0 (#2077)
Bump golang.org/x/sys from 0.2.0 to 0.3.0 (#2078)
Ignore Kubernetes Dependencies in Dependabot (#2071)
Bump github.com/prometheus/client_golang from 1.13.0 to 1.14.0 (#2070)
Bump github.com/onsi/ginkgo/v2 from 2.5.0 to 2.5.1 (#2066)
seedling to dependabot (#2065)
Bump github.com/onsi/gomega from 1.23.0 to 1.24.1 (#2062)
Bump go.uber.org/zap from 1.21.0 to 1.23.0 (#2060)
Bump actions/checkout from 2 to 3 (#2059)
Bump golangci/golangci-lint-action from 2 to 3 (#2058)
Add Dependabot for dependency management (#2050)
Deprecate Webhook Server TLSMinVersion (#2041)
Bump kubebuilder-release-tools to v0.2.0 (#2012)
grammar: removed doubles of the word "the" (#2006)
Refactor typed_client and unstructured_client to be consistent (#1795)

📖 Additionally, there have been 4 contributions to our documentation and book. (#2034, #2030, #2017, #1992)

Thanks to all our contributors! 😊

New Contributors

@laxmikantbpandhare made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/1986
@Icarus9913 made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/1992
@Tomy2e made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/1970
@hyschumi made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/1795
@oscr made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/2006
@matteoolivi made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/2017
@johscheuer made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/2027
@larsks made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/2030
@johannesfrey made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/1999
@Eileen-Yu made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/2034
@iiiceoo made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/2049
@kannon92 made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/2050
@zbindenren made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/2056
@dependabot made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/2058
@Miciah made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/2057
@maciej-karas-form3 made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/2051
@qiankunli made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/2076
@lucacome made their first contribution in https://github.com/kubernetes-sigs/controller-runtime/pull/2087

Full Changelog: kubernetes-sigs/controller-runtime@v0.13.1...v0.14.0

Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

openshift-ci · 2023-01-12T18:04:04Z

Hi @renovate[bot]. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gibizer

I'm confused. This fails with the known issue locally in make test make gotest or by runnig gotest.sh from the CI repo:

unable to install CRDs onto control plane: unable to create CRD instances: unable to create CRD "novaapis.nova.openstack.org": CustomResourceDefinition.apiextensions.k8s.io "novaapis.nova.openstack.org" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[resources].properties[claims].items.x-kubernetes-map-type: Invalid value: "null": must be atomic as item of a list with x-kubernetes-list-type=set

But in the github workflow the test runs without error.

SeanMooney · 2023-01-12T19:13:29Z

api/go.mod

@@ -4,9 +4,9 @@ go 1.18

 require (
 	github.com/openstack-k8s-operators/lib-common/modules/common v0.0.0-20230110110231-28368fe6a6a9
-	k8s.io/api v0.25.5
+	k8s.io/api v0.26.0


this is the issue we need to clamp to < v0.26.0

SeanMooney · 2023-01-12T19:13:37Z

this is the same issue as openstack-k8s-operators/openstack-ansibleee-operator#45

SeanMooney · 2023-01-12T21:08:53Z

/ok-to-test

lets see if the prow jobs also fail or not

SeanMooney · 2023-01-12T21:15:30Z

so yes this fails for me locally too

 [FAILED] in [BeforeSuite] - /home/centos/repos/nova-operator/test/functional/suite_test.go:105 @ 01/12/23 16:14:21.476
  << Timeline

  [FAILED] Unexpected error:
      <*fmt.wrapError | 0xc000d087c0>: {
          msg: "unable to install CRDs onto control plane: unable to create CRD instances: unable to create CRD \"novanovncproxies.nova.openstack.org\": CustomResourceDefinition.apiextensions.k8s.io \"novanovncproxies.nova.openstack.org\" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[resources].properties[claims].items.x-kubernetes-map-type: Invalid value: \"null\": must be atomic as item of a list with x-kubernetes-list-type=set",
          err: <*fmt.wrapError | 0xc000d087a0>{
              msg: "unable to create CRD instances: unable to create CRD \"novanovncproxies.nova.openstack.org\": CustomResourceDefinition.apiextensions.k8s.io \"novanovncproxies.nova.openstack.org\" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[resources].properties[claims].items.x-kubernetes-map-type: Invalid value: \"null\": must be atomic as item of a list with x-kubernetes-list-type=set",
              err: <*fmt.wrapError | 0xc000d08780>{
                  msg: "unable to create CRD \"novanovncproxies.nova.openstack.org\": CustomResourceDefinition.apiextensions.k8s.io \"novanovncproxies.nova.openstack.org\" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[resources].properties[claims].items.x-kubernetes-map-type: Invalid value: \"null\": must be atomic as item of a list with x-kubernetes-list-type=set",
                  err: <*errors.StatusError | 0xc000125ea0>{
                      ErrStatus: {
                          TypeMeta: {Kind: "", APIVersion: ""},
                          ListMeta: {
                              SelfLink: "",
                              ResourceVersion: "",
                              Continue: "",
                              RemainingItemCount: nil,
                          },
                          Status: "Failure",
                          Message: "CustomResourceDefinition.apiextensions.k8s.io \"novanovncproxies.nova.openstack.org\" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[resources].properties[claims].items.x-kubernetes-map-type: Invalid value: \"null\": must be atomic as item of a list with x-kubernetes-list-type=set",
                          Reason: "Invalid",
                          Details: {
                              Name: "novanovncproxies.nova.openstack.org",
                              Group: "apiextensions.k8s.io",
                              Kind: "CustomResourceDefinition",
                              UID: "",
                              Causes: [
                                  {
                                      Type: "FieldValueInvalid",
                                      Message: "Invalid value: \"null\": must be atomic as item of a list with x-kubernetes-list-type=set",
                                      Field: "spec.validation.openAPIV3Schema.properties[spec].properties[resources].properties[claims].items.x-kubernetes-map-type",
                                  },
                              ],
                              RetryAfterSeconds: 0,
                          },
                          Code: 422,
                      },
                  },
              },
          },
      }
      unable to install CRDs onto control plane: unable to create CRD instances: unable to create CRD "novanovncproxies.nova.openstack.org": CustomResourceDefinition.apiextensions.k8s.io "novanovncproxies.nova.openstack.org" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[resources].properties[claims].items.x-kubernetes-map-type: Invalid value: "null": must be atomic as item of a list with x-kubernetes-list-type=set



Summarizing 1 Failure:
  [FAIL] [BeforeSuite] 
  /home/centos/repos/nova-operator/test/functional/suite_test.go:105

Ran 0 of 73 Specs in 8.038 seconds
FAIL! -- A BeforeSuite node failed so all tests were skipped.
--- FAIL: TestAPIs (8.04s)

SeanMooney · 2023-01-12T21:16:59Z

make test catches that failure if you have the new version fo ginkgo

gibizer · 2023-01-13T09:11:32Z

make test catches that failure if you have the new version fo ginkgo

Is it really gingko version dependant?

Btw, the prow functional job also passed. That calls make gotest as far as I remember (the logs are not available now for some reason). And make gotest fails for me locally.

gibizer · 2023-01-13T09:18:22Z

but also interestingly make manifest in the pre-commit prow job generated new content that I cannot generate locally. And it contains things like x-kubernetes-list-type that seems to be related to the CRD failure.

gibizer · 2023-01-13T09:24:43Z

but also interestingly make manifest in the pre-commit prow job generated new content that I cannot generate locally. And it contains things like x-kubernetes-list-type that seems to be related to the CRD failure.

scratch that, the same manifest changes happens locally too. Let me try to add that to this commit to see if that helps with the test run now.

gibizer · 2023-01-13T09:41:54Z

Good I understand why test passed before on this PR. The make test target calls make manifest that generates the new CRD pieces which causing the CRD validation error. BUT neither make gotest nor the go test will force the generation of the manifests therefore neither the github action running the test nor the prow functional caught this. Furtunately pre-commit runs make manifests and fails if there is a diff. (+1 for pre-commit) Now that the CRD changes are committed in to this PR both the github action and the prow job fails as expected with the CRD validation error. \o/

So couple of way forwards:

long term we will host our own renovate executor and there we can enable https://docs.renovatebot.com/configuration-options/#postupgradetasks to run make manifests and commit the diff.
short term I can add manifest as a dependency to make gotest and change the github workflow not to call go test but call the make target instead

gibizer · 2023-01-20T14:13:41Z

(gibi): manually run make manifests generate to include the CRD changes

gibizer · 2023-01-20T14:20:14Z

/retest all

openshift-ci · 2023-01-20T14:20:17Z

@gibizer: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test functional
/test gofmt
/test golangci
/test golint
/test govet
/test images
/test precommit-check

Use /test all to run all jobs.

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gibizer · 2023-01-20T14:20:36Z

/test all

gibizer · 2023-01-20T14:37:24Z

OK so the recent k8s.io packages now compatible with the controller-gen. This is ready to land (openstack-operator already landed a similar bump)

renovate · 2023-01-30T17:19:54Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

fixed

gibizer

I did a local build and test in crc and it works.

openshift-ci · 2023-01-30T17:46:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, renovate[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gibizer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from bogdando and SeanMooney January 12, 2023 18:03

openshift-ci bot added the needs-ok-to-test label Jan 12, 2023

gibizer previously requested changes Jan 12, 2023

View reviewed changes

openshift-ci bot assigned gibizer Jan 12, 2023

SeanMooney reviewed Jan 12, 2023

View reviewed changes

openshift-ci bot added ok-to-test and removed needs-ok-to-test labels Jan 12, 2023

gibizer force-pushed the renovate/k8s.io branch from c596fb1 to 89253dd Compare January 13, 2023 09:27

gibizer mentioned this pull request Jan 13, 2023

bump deps #226

Closed

renovate bot force-pushed the renovate/k8s.io branch 5 times, most recently from b11f4c2 to b671087 Compare January 20, 2023 13:03

gibizer force-pushed the renovate/k8s.io branch from b671087 to 83f631c Compare January 20, 2023 14:13

renovate bot force-pushed the renovate/k8s.io branch from 83f631c to 39457d2 Compare January 20, 2023 14:16

gibizer mentioned this pull request Jan 20, 2023

WIP bumping k8s apis to 0.26.0 and controller runtime to 0.14.0 #200

Closed

renovate bot force-pushed the renovate/k8s.io branch 2 times, most recently from 9e156c6 to 1a2e93d Compare January 27, 2023 20:31

Update k8s.io

b66c605

renovate bot force-pushed the renovate/k8s.io branch from 1a2e93d to b66c605 Compare January 30, 2023 15:06

Regenerate manifest with the new deps

205a29e

gibizer approved these changes Jan 30, 2023

View reviewed changes

openshift-ci bot added the lgtm label Jan 30, 2023

openshift-ci bot added the approved label Jan 30, 2023

openshift-merge-robot merged commit e2be824 into master Jan 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update k8s.io #224

Update k8s.io #224

renovate bot commented Jan 12, 2023 •

edited

Loading

openshift-ci bot commented Jan 12, 2023

gibizer left a comment

SeanMooney Jan 12, 2023

gibizer Jan 13, 2023

SeanMooney commented Jan 12, 2023

SeanMooney commented Jan 12, 2023

SeanMooney commented Jan 12, 2023 •

edited

Loading

SeanMooney commented Jan 12, 2023

gibizer commented Jan 13, 2023 •

edited

Loading

gibizer commented Jan 13, 2023

gibizer commented Jan 13, 2023

gibizer commented Jan 13, 2023

gibizer commented Jan 20, 2023

gibizer commented Jan 20, 2023

openshift-ci bot commented Jan 20, 2023

gibizer commented Jan 20, 2023

gibizer commented Jan 20, 2023

renovate bot commented Jan 30, 2023

gibizer left a comment

openshift-ci bot commented Jan 30, 2023

Update k8s.io #224

Update k8s.io #224

Conversation

renovate bot commented Jan 12, 2023 • edited Loading

Release Notes

What's Changed

Changes since v0.14.0

🐛 Bug Fixes

Changes since v0.13.1

⚠️ Breaking Changes

✨ New Features

🐛 Bug Fixes

🌱 Others

New Contributors

Configuration

openshift-ci bot commented Jan 12, 2023

gibizer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SeanMooney commented Jan 12, 2023

SeanMooney commented Jan 12, 2023

SeanMooney commented Jan 12, 2023 • edited Loading

SeanMooney commented Jan 12, 2023

gibizer commented Jan 13, 2023 • edited Loading

gibizer commented Jan 13, 2023

gibizer commented Jan 13, 2023

gibizer commented Jan 13, 2023

gibizer commented Jan 20, 2023

gibizer commented Jan 20, 2023

openshift-ci bot commented Jan 20, 2023

gibizer commented Jan 20, 2023

gibizer commented Jan 20, 2023

renovate bot commented Jan 30, 2023

Edited/Blocked Notification

gibizer left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jan 30, 2023

renovate bot commented Jan 12, 2023 •

edited

Loading

SeanMooney commented Jan 12, 2023 •

edited

Loading

gibizer commented Jan 13, 2023 •

edited

Loading