Refactor our defer calls #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our defer call at the end of Reconcile does two things: 1) update the Ready condition of the instance if all the other conditions are in True state 2) persist the metadata and the status changes of the object into etcd. The #2 is complicated but common for each of our controllers so it is pulled out and the impl moved to ReconcileBase.
abays
reviewed
Dec 13, 2022
SeanMooney
approved these changes
Dec 15, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our defer call at the end of Reconcile does two things:
conditions are in True state
The 2 is complicated but common for each of our controllers so it is pulled out and the impl moved to ReconcileBase. Note that this automatically adds metadata patching capabilities to those controllers (e.g. cell) that does not need it today.