Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go to 1.21 #412

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Update Go to 1.21 #412

merged 2 commits into from
Sep 25, 2024

Conversation

bshephar
Copy link
Contributor

@bshephar bshephar commented Sep 17, 2024 •
edited by openshift-ci bot
Loading

  • bump in go.mod (base and api)
  • bump go-toolset in Dockerfile
  • bump in github jobs ('.github/workflows')
  • Bump the golangci-lint version in the .pre-commit-config.yaml to v1.59.1 (1.60 >= golang 1.22; 1.61 >= golang 1.23)
  • Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.21-sdk-1.31

Jira: OSPRH-6501

@bshephar
Update Go to 1.21
d2b564c 
* bump in go.mod (base and api)
* bump go-toolset in Dockerfile
* bump in github jobs ('.github/workflows')
* Bump the golangci-lint version in the .pre-commit-config.yaml to v1.59.1 (1.60 >= golang 1.22; 1.61 >= golang 1.23)
* Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.21-sdk-1.31

Jira: OSPRH-6501
Signed-off-by: Brendan Shephard <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5f7e0e17f26e4f6fa62d9c6a245a0e3a

❌ openstack-k8s-operators-content-provider FAILURE in 6m 45s
⚠️ neutron-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d516f21199a843e78335bb8bbaa1c5ac

❌ openstack-k8s-operators-content-provider FAILURE in 7m 54s
⚠️ neutron-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

stuggi
stuggi reviewed Sep 24, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@stuggi
Copy link
Contributor

stuggi commented Sep 24, 2024

/retest

@stuggi
Copy link
Contributor

stuggi commented Sep 24, 2024

recheck

@bshephar
Set minimum Go version via env var
fa3c5b8 
GOTOOLCHAIN to set 1.21.0 as the min required version and sets it in go.work file.

Signed-off-by: Brendan Shephard <[email protected]>
stuggi
stuggi approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi stuggi added the lgtm label Sep 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 928e09f into openstack-k8s-operators:main Sep 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuggi stuggi stuggi approved these changes

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

Assignees

@stuggi stuggi

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshephar @stuggi