run lint

Fix comments, add const
openstack-k8s-operators · Jun 23, 2023 · b530cc0 · b530cc0
1 parent 7c468ae
commit b530cc0
Show file tree

Hide file tree

Showing 7 changed files with 28 additions and 10 deletions.
diff --git a/api/bases/neutron.openstack.org_neutronapis.yaml b/api/bases/neutron.openstack.org_neutronapis.yaml
@@ -2096,8 +2096,8 @@ spec:
                 description: RouteAnnotations to be added to the created route
                 properties:
                   timeout:
-                    default: "60"
-                    description: HAProxy Timeout for route
+                    description: Timeout - Provides the HAProxy Timeout value for
+                      the route
                     type: string
                 type: object
               secret:

diff --git a/api/v1beta1/neutronapi_types.go b/api/v1beta1/neutronapi_types.go
@@ -198,10 +198,10 @@ type NeutronAPIDebug struct {
 	Service bool `json:"service"`
 }
 
+// NeutronRouteAnnotations defines the route annotations
 type NeutronRouteAnnotations struct {
 	// +kubebuilder:validation:Optional
-	// +kubebuilder:default="60"
-	// HAProxy Timeout for route
+	// Timeout - Provides the HAProxy Timeout value for the route
 	Timeout string `json:"timeout"`
 }
 

diff --git a/api/v1beta1/zz_generated.deepcopy.go b/api/v1beta1/zz_generated.deepcopy.go
diff --git a/config/crd/bases/neutron.openstack.org_neutronapis.yaml b/config/crd/bases/neutron.openstack.org_neutronapis.yaml
@@ -2096,8 +2096,8 @@ spec:
                 description: RouteAnnotations to be added to the created route
                 properties:
                   timeout:
-                    default: "60"
-                    description: HAProxy Timeout for route
+                    description: Timeout - Provides the HAProxy Timeout value for
+                      the route
                     type: string
                 type: object
               secret:

diff --git a/config/samples/neutron_v1beta1_neutronapi.yaml b/config/samples/neutron_v1beta1_neutronapi.yaml
@@ -19,4 +19,4 @@ spec:
   replicas: 1
   secret: neutron-secret
   routeAnnotations:
-    timeout: 120s
+    timeout: 120s
diff --git a/controllers/neutronapi_controller.go b/controllers/neutronapi_controller.go
@@ -59,6 +59,10 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
+const (
+	routeTimeoutAnnotationName string = "haproxy.router.openshift.io/timeout"
+)
+
 // NeutronAPIReconciler reconciles a NeutronAPI object
 type NeutronAPIReconciler struct {
 	client.Client
@@ -414,7 +418,7 @@ func (r *NeutronAPIReconciler) reconcileInit(
 
 	routeAnnotations := make(map[string]string)
 	if instance.Spec.RouteAnnotations.Timeout != "" {
-		routeAnnotations["haproxy.router.openshift.io/timeout"] = instance.Spec.RouteAnnotations.Timeout
+		routeAnnotations[routeTimeoutAnnotationName] = instance.Spec.RouteAnnotations.Timeout
 	}
 
 	apiEndpoints, ctrlResult, err := endpoint.ExposeEndpoints(

diff --git a/go.mod b/go.mod
@@ -89,5 +89,3 @@ require (
 )
 
 replace github.com/openstack-k8s-operators/neutron-operator/api => ./api
-
-replace github.com/openstack-k8s-operators/lib-common/modules/common => /Users/ldenny/Code/openstack/openstack-operators/lib-common/modules/common
Original file line number	Diff line number	Diff line change
Expand Up		@@ -89,5 +89,3 @@ require (
		)

		replace github.com/openstack-k8s-operators/neutron-operator/api => ./api

		replace github.com/openstack-k8s-operators/lib-common/modules/common => /Users/ldenny/Code/openstack/openstack-operators/lib-common/modules/common