Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre commit #67

Merged

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Feb 9, 2023

It seems the pre-commit config was merged without running pre-commit on the repo ever. This patch fixes the pre-commit findings.

  • setting executable flag for scripts
  • adding operator-lint and gowork target and fixing lint findings.

It seems the pre-commit config was merged without running pre-commit on
the repo ever. This patch fixes the pre-commit finding.
It seems the pre-commit config was merged without running pre-commit on
the repo ever. This patch fixes the pre-commit finding by adding the
missing operator-lint and gowork make targets and fixing the lint
findings.
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, gibizer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit 509a806 into openstack-k8s-operators:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants