Allow intermediate replicas to ease operation #276
Merged
+28
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the mariadb operator has webhooks to enforce the galera replica count to be either 1 or 3, which are the two supported deployments on the OpenstackControlPlane. However there is a need for more flexibility for day two operations, where it can be useful to allow scaling down replicas temporarily to e.g. 2 (for replacement procedure) or even 0 (to temporarily disable database management). Replace the kubebuilder annotations with minimum and maximum, and let the galera webhook warn about setting replicas to 2 (as it is not advisable to keep that setting for quorum concerns).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, dciabrin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b0954ab
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the mariadb operator has webhooks to enforce the galera replica count to be either 1 or 3, which are the two supported deployments on the OpenstackControlPlane.
However there is a need for more flexibility for day two operations, where it can be useful to allow scaling down replicas temporarily to e.g. 2 (for replacement procedure) or even 0 (to temporarily disable database management).
Replace the kubebuilder annotations with minimum and maximum, and let the galera webhook warn about setting replicas to 2 (as it is not advisable to keep that setting for quorum concerns).