detect ipv6 stack and apply correct listen address #180
Conversation
|
/test mariadb-operator-build-deploy-kuttl
|
| PODIP="${PODIPV4}" | ||
| IPSTACK="IPV4" | ||
| else | ||
| PODIP="[::]" |
There was a problem hiding this comment.
Do we need all this logic?
If we are defaulting to listen on all interfaces in case IPv6 or Dual-Stack IPv6-and-Ipv4 - Can we now simply configure it with "[::]" for all cases?
There was a problem hiding this comment.
it has to work on an ipv4-only stack as well, IIUC galera needs the specific IP number to bind onto in that case cc @dciabrin
There was a problem hiding this comment.
We started using [::] for IPv6 as per openstack-archive/puppet-tripleo@84ba7c3.
Galera is probably able to cope with other direct IPv6 addresses now, but that is to be verified. Until then, I think we are good enough with that as it's not a regression from what we used to have.
|
/test mariadb-operator-build-deploy-kuttl
|
|
/retest |
1 similar comment
|
/retest |
on a dual-stack host (or an ipv6 only host), detect the ipv6 and ipv4 addresses individually from /etc/hosts and apply '[::]' as the gmcast_listen address if ipv6 is present. Fixes: https://issues.redhat.com/browse/OSPRH-3330
|
/retest |
|
now it passes after i put a node hold in. faceslap |
|
/retest |
1 similar comment
|
/retest |
There was a problem hiding this comment.
I'm ok with this.
But I do find it weird that we choose to specify a "listen" address to bind to when using IPv4 - but then if it is IPv6 or IPv4+IPv6 (dual stack) we accept a config that make it listen to any interface.
It seems to me we can use either '0.0.0.0' or '[::]' for all cases instead.
@dciabrin can you comment on this? |
I'm still unclear about the general consensus as to listen in container: should we explicitly listen on the interface we expect to receive traffic from, or is listening on all interface and assume k8s plumbing is sufficient to not expose unnecessary interfaces. As I said earlier this IPv6 patch is what we used back in the days because we had issues specifying IPv6 addresses with galera. So I think this is good enough to fix the original reported issue, and we should probably revisit it to either specify a full IPv6 address is recent galera allows it, or listen to all interfaces if that is a general pattern in pods networking. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dciabrin, hjensas, zzzeek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1a86db2
into
openstack-k8s-operators:main
on a dual-stack host (or an ipv6 only host), detect the ipv6 and ipv4 addresses individually from /etc/hosts and apply '[::]' as the gmcast_listen address if ipv6 is present.
Fixes: https://issues.redhat.com/browse/OSPRH-3330