Do not use strings.TrimPrefix to get ShareName #358
Merged
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As done with cinder as part of [1], to make manila consistent with that work, this patch removes the need of using strings.TrimPrefix and instead relies on ShareName() function, that returns the instance name stored as label in every manilaShare instance. [1] openstack-k8s-operators/cinder-operator#463 Signed-off-by: Francesco Pantano <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test manila-operator-build-deploy-kuttl |
openshift-merge-bot
bot
merged commit 61488e9
into
openstack-k8s-operators:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As done with Cinder as part of [1], and to make Manila consistent with that work, this patch removes the need of using
strings.TrimPrefixand instead relies on theShareName()function that returns the instance name stored as label in everymanilaShareinstance.[1] openstack-k8s-operators/cinder-operator#463