Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DefaultConfigOverwrite from CRD #180

Merged

Conversation

fmount
Copy link
Collaborator

@fmount fmount commented Nov 14, 2023

As done in Cinder via [1], this patch removes the DefaultConfigOverwrite parameter from the CRD.
The feature was never fully implemented, and it's superseded by the ExtraMounts feature.

[1] openstack-k8s-operators/cinder-operator#297

The feature was never fully implemented, and it's superseded by
the ExtraMounts feature.

Signed-off-by: Francesco Pantano <[email protected]>
@fmount fmount requested a review from ASBishop November 14, 2023 12:44
@openshift-ci openshift-ci bot requested review from abays and dprince November 14, 2023 12:44
@fmount fmount requested a review from gouthampacha November 14, 2023 12:44
Copy link
Contributor

openshift-ci bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gouthampacha
Copy link
Contributor

/retest

@fmount
Copy link
Collaborator Author

fmount commented Nov 15, 2023

/test manila-operator-build-deploy-tempest

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me if we've decided to do this across-the-board for all operators

@gouthampacha
Copy link
Contributor

+1 from me if we've decided to do this across-the-board for all operators

+1 from me as well; the discussion elsewhere seemed to indicate a split between wanting this over extraMounts in some other operators - because they have a specific use case that we don't have in cinder/manila/glance operators. We support extraMounts for a range of purposes already, having this is a small overlap/duplication, we could document this disparity and merge?

@fmount
Copy link
Collaborator Author

fmount commented Nov 20, 2023

+1 from me if we've decided to do this across-the-board for all operators

+1 from me as well; the discussion elsewhere seemed to indicate a split between wanting this over extraMounts in some other operators - because they have a specific use case that we don't have in cinder/manila/glance operators. We support extraMounts for a range of purposes already, having this is a small overlap/duplication, we could document this disparity and merge?

+1, we could as a follow up of openstack-k8s-operators/dev-docs#31 where we collected the general method of providing config to the services

@gouthampacha
Copy link
Contributor

/lgtm

This was removed in the cinder-operator via: openstack-k8s-operators/cinder-operator#297

@openshift-ci openshift-ci bot added the lgtm label Nov 27, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 81ffbc2 into openstack-k8s-operators:main Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants