-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DefaultConfigOverwrite from CRD #180
Remove DefaultConfigOverwrite from CRD #180
Conversation
The feature was never fully implemented, and it's superseded by the ExtraMounts feature. Signed-off-by: Francesco Pantano <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test manila-operator-build-deploy-tempest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me if we've decided to do this across-the-board for all operators
+1 from me as well; the discussion elsewhere seemed to indicate a split between wanting this over |
+1, we could as a follow up of openstack-k8s-operators/dev-docs#31 where we collected the general method of providing config to the services |
/lgtm This was removed in the cinder-operator via: openstack-k8s-operators/cinder-operator#297 |
81ffbc2
into
openstack-k8s-operators:main
As done in Cinder via [1], this patch removes the
DefaultConfigOverwrite
parameter from theCRD
.The feature was never fully implemented, and it's superseded by the
ExtraMounts
feature.[1] openstack-k8s-operators/cinder-operator#297