Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manilaapi to use service override #130

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Sep 7, 2023

Removes creation of routes.Those get done in the openstack-operator. Via service overrides the service can be customized. The service operator adds annotation to the service which needs to be exposed as a route.

Jira: OSP-26690

Depends-On: openstack-k8s-operators/lib-common#332

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor Author

stuggi commented Sep 7, 2023

/hold

@stuggi
Copy link
Contributor Author

stuggi commented Sep 20, 2023

/test manila-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor Author

stuggi commented Sep 20, 2023

The issue we right now is that the we are building the new operator with the current version of the openstack-operator which has not the functionality to create the route for the new service operator version. With this the public endpoint will be a ClusterIP service and is not reachable by the tempest job which is running outside the OCP env.

I think we have two options:

  • update the current samples in the openstack-operator for network-isolation (if that is used by tempest) to also use a LoadBalancer type service for the public endpoint and see if that works for the tempest job
  • force merge with failed tempest job result until we merged the openstack-operator PR

@stuggi
Copy link
Contributor Author

stuggi commented Sep 20, 2023

The issue we right now is that the we are building the new operator with the current version of the openstack-operator which has not the functionality to create the route for the new service operator version. With this the public endpoint will be a ClusterIP service and is not reachable by the tempest job which is running outside the OCP env.

I think we have two options:

  • update the current samples in the openstack-operator for network-isolation (if that is used by tempest) to also use a LoadBalancer type service for the public endpoint and see if that works for the tempest job

This would only work if the host tempest is running is using our DNS server where the service endpoint gets registered

  • force merge with failed tempest job result until we merged the openstack-operator PR

Removes creation of routes.Those get done in the openstack-operator.
Via service overrides the service can be customized. The service operator
adds annotation to the service which needs to be exposed as a route.

Jira: OSP-26690

Depends-On: openstack-k8s-operators/lib-common#332
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

@stuggi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/manila-operator-build-deploy-tempest e048f84 link true /test manila-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fmount
Copy link
Collaborator

fmount commented Sep 21, 2023

The issue we right now is that the we are building the new operator with the current version of the openstack-operator which has not the functionality to create the route for the new service operator version. With this the public endpoint will be a ClusterIP service and is not reachable by the tempest job which is running outside the OCP env.
I think we have two options:

  • update the current samples in the openstack-operator for network-isolation (if that is used by tempest) to also use a LoadBalancer type service for the public endpoint and see if that works for the tempest job

This would only work if the host tempest is running is using our DNS server where the service endpoint gets registered

  • force merge with failed tempest job result until we merged the openstack-operator PR

I agree we should force-merge these patches and avoid growing the patch series to get the Routes creation moved at the openstack-operator level.
I'm going to force-merge this and work with @stuggi to land the whole patch chain, otherwise any other patch will be stuck failing in CI.

@fmount fmount merged commit 996d4e3 into openstack-k8s-operators:main Sep 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants