Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DaemonSet module #80

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Add DaemonSet module #80

merged 1 commit into from
Oct 24, 2022

Conversation

slawqo
Copy link
Contributor

@slawqo slawqo commented Oct 19, 2022

No description provided.

stuggi
stuggi approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

gibizer
gibizer requested changes Oct 19, 2022
View reviewed changes
modules/common/daemonset/daemonset.go Outdated Show resolved Hide resolved
modules/common/daemonset/daemonset.go Outdated Show resolved Hide resolved
modules/common/daemonset/daemonset.go Outdated Show resolved Hide resolved
modules/common/daemonset/daemonset.go Outdated Show resolved Hide resolved
modules/common/daemonset/daemonset.go Show resolved Hide resolved
modules/common/daemonset/daemonset.go Outdated Show resolved Hide resolved
modules/common/daemonset/daemonset.go Outdated Show resolved Hide resolved
abays
abays approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@slawqo slawqo force-pushed the work/slaweq/daemonset branch from 507c351 to 2a5ba4f Compare October 20, 2022 08:36
gibizer
gibizer requested changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. I have some followup inline.

modules/common/daemonset/daemonset.go Outdated Show resolved Hide resolved
modules/common/daemonset/daemonset.go Outdated Show resolved Hide resolved
modules/common/daemonset/daemonset.go Outdated Show resolved Hide resolved
modules/common/daemonset/daemonset.go Show resolved Hide resolved
@slawqo slawqo force-pushed the work/slaweq/daemonset branch from 2a5ba4f to f489f25 Compare October 20, 2022 16:29
gibizer
gibizer approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks.

stuggi
stuggi approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@abays abays merged commit 4dd3b2d into master Oct 24, 2022
@jpodivin jpodivin deleted the work/slaweq/daemonset branch October 11, 2023 14:15
@jpodivin jpodivin restored the work/slaweq/daemonset branch October 11, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abays abays abays approved these changes

@stuggi stuggi stuggi approved these changes

@gibizer gibizer gibizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slawqo @gibizer @abays @stuggi