A custom slimmed down version of VolumeSource

[dprince]

Slim down VolumeSource by removing deprecated and "removed" fields from the struct. This will slim down our nested use of ExtraMounts.

Using this version of the struct shaves 38k off the cinder-operator bundle size. Using this across the board would have a significant effect on reducing the OpenStackControlplane CRD size and little if any effect on utility of the nested ExtraMount struct.

[dprince]

A preview of the effect on cinder-operator is here: dprince/cinder-operator@95e834d

[dprince]

@olliewalsh This is similar to the StatefulSet idea you mentioned from Rabbit.

[dprince]

I removed zz_generated.deepcopy.go as the Makefile here doesn't seem to regenerate it. (just stale). Did something get broken recently?

[bshephar]

We might want to leave additional things to allow the most customer possibilities. But just floating the idea of removing a few more things if they aren't explicitly supported by OpenShift.

[dprince]

@bshephar the more we can agree to remove the better.

[fmount]

I removed zz_generated.deepcopy.go as the Makefile here doesn't seem to regenerate it. (just stale). Did something get broken recently?

Not sure, but [1] should solve your problem here.

[1] https://paste.opendev.org/show/bUqTCs84vk01M2PefMn0/

[fmount]

@dprince an additional change we need to consider across all the operators that implement extraMounts is the way we access corev1.Volumes.

We usually append( ... a corev1.Volume to an array of the same type, and we need to patch functions like [1] to work with the Volumes struct defined in this module (but Make will tell you more about this comment).

With the goal in mind of reducing the bundle size, I think we're going in the right direction, and I can follow up w/ a glance-operator change (because it's simple) that is based on this patch.
If everyone agrees on that we can then prepare changes for all the operators implementing this new version.

[1] https://github.com/openstack-k8s-operators/cinder-operator/blob/main/pkg/cindervolume/volumes.go#L30

[dprince]

I removed zz_generated.deepcopy.go as the Makefile here doesn't seem to regenerate it. (just stale). Did something get broken recently?

Not sure, but [1] should solve your problem here.

[1] https://paste.opendev.org/show/bUqTCs84vk01M2PefMn0/

I'm not sure how the storage modules deepcopy was ever maintained. It is missing the needed kubebuilder annotations to do so

[dprince]

@dprince an additional change we need to consider across all the operators that implement extraMounts is the way we access corev1.Volumes.

We usually append( ... a corev1.Volume to an array of the same type, and we need to patch functions like [1] to work with the Volumes struct defined in this module (but Make will tell you more about this comment).

With the goal in mind of reducing the bundle size, I think we're going in the right direction, and I can follow up w/ a glance-operator change (because it's simple) that is based on this patch. If everyone agrees on that we can then prepare changes for all the operators implementing this new version.

[1] https://github.com/openstack-k8s-operators/cinder-operator/blob/main/pkg/cindervolume/volumes.go#L30

I updated my cinder PR. Wanted to get general feedback on this before going too far but I think it should work out fine.

[stuggi]

/lgtm

[fmount]

/lgtm